Bug 134296

Summary: feBlend should support all blend modes from CSS and Canvas
Product: WebKit Reporter: Dirk Schulze <krit>
Component: SVGAssignee: Dirk Schulze <krit>
Status: RESOLVED FIXED    
Severity: Normal CC: bunhere, cdumez, commit-queue, dino, d-r, fmalita, gyuyoung.kim, kondapallykalyan, pdr, schenney, sergio, zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 68469    
Attachments:
Description Flags
Patch
none
Patch
none
Patch- next try
none
Patch- next try
none
Patch
none
Patch none

Description Dirk Schulze 2014-06-25 05:22:17 PDT
feBlend should support all blend modes from CSS and Canvas
Comment 1 Dirk Schulze 2014-06-25 05:38:27 PDT
Created attachment 233807 [details]
Patch
Comment 2 Dirk Schulze 2014-06-25 06:58:57 PDT
Created attachment 233808 [details]
Patch
Comment 3 Dirk Schulze 2014-06-25 07:03:25 PDT
Hmpf... it would be great to know what the problem is... there is no indicator at all in the log.
Comment 4 Dirk Schulze 2014-06-25 07:09:08 PDT
Created attachment 233809 [details]
Patch- next try
Comment 5 Dirk Schulze 2014-06-25 07:11:51 PDT
Created attachment 233810 [details]
Patch- next try
Comment 6 WebKit Commit Bot 2014-06-25 07:12:44 PDT
Attachment 233810 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/cpu/arm/filters/FEBlendNEON.h:129:  Multi line control clauses should use braces.  [whitespace/braces] [4]
Total errors found: 1 in 18 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Dirk Schulze 2014-06-25 08:21:26 PDT
Created attachment 233813 [details]
Patch
Comment 8 Dirk Schulze 2014-06-25 08:39:00 PDT
Created attachment 233814 [details]
Patch
Comment 9 WebKit Commit Bot 2014-06-25 12:04:12 PDT
Comment on attachment 233814 [details]
Patch

Clearing flags on attachment: 233814

Committed r170433: <http://trac.webkit.org/changeset/170433>
Comment 10 WebKit Commit Bot 2014-06-25 12:04:17 PDT
All reviewed patches have been landed.  Closing bug.