|Summary:||Remove build guard for progress element|
|Product:||WebKit||Reporter:||Laszlo Gombos <laszlo.gombos>|
|Component:||WebCore Misc.||Assignee:||Laszlo Gombos <laszlo.gombos>|
|Severity:||Normal||CC:||aboxhall, allan.jensen, apinheiro, benjamin, buildbot, bunhere, cdumez, cfleizach, cmarcelo, commit-queue, dbates, dmazzoni, esprehn+autocc, glenn, gyuyoung.kim, jcraig, jdiggs, kondapallykalyan, macpherson, mario, menard, mitz, rakuco, rniwa, samuel_white, sergio, zalan|
|Version:||528+ (Nightly build)|
Description Laszlo Gombos 2014-06-24 22:48:42 PDT
It seems that ENABLE(PROGRESS_ELEMENT) is set to 1 for all ports by default. Also I do not see why anyone would want to disable this feature as it is very mature. I propose to remove the build flag.
Comment 2 Benjamin Poulain 2014-06-24 23:22:00 PDT
Comment on attachment 233791 [details] 1st try Go for it, that's a good idea.
Comment 3 Build Bot 2014-06-25 00:39:53 PDT
Comment on attachment 233791 [details] 1st try Attachment 233791 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5818197857009664 New failing tests: media/W3C/video/networkState/networkState_during_loadstart.html
Comment 4 Build Bot 2014-06-25 00:40:00 PDT
Created attachment 233797 [details] Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-13 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Comment 5 Laszlo Gombos 2014-06-25 04:33:27 PDT
Comment on attachment 233791 [details] 1st try The failure seems to be an independent issue (Process failed to become responsive before timing out), lets try again..
Comment 6 WebKit Commit Bot 2014-06-25 05:05:09 PDT
Comment on attachment 233791 [details] 1st try Clearing flags on attachment: 233791 Committed r170425: <http://trac.webkit.org/changeset/170425>
Comment 7 WebKit Commit Bot 2014-06-25 05:05:17 PDT
All reviewed patches have been landed. Closing bug.
Comment 8 mitz 2014-06-25 09:16:36 PDT
(In reply to comment #6) > (From update of attachment 233791 [details]) > Clearing flags on attachment: 233791 > > Committed r170425: <http://trac.webkit.org/changeset/170425> This broke the iOS build.
Comment 9 zalan 2014-06-25 10:02:25 PDT
(In reply to comment #8) > (In reply to comment #6) > > (From update of attachment 233791 [details] [details]) > > Clearing flags on attachment: 233791 > > > > Committed r170425: <http://trac.webkit.org/changeset/170425> > > This broke the iOS build. http://trac.webkit.org/changeset/170430