Bug 134292

Summary:

Remove build guard for progress element

Product:

WebKit

Reporter:

Laszlo Gombos <laszlo.gombos>

Component:

WebCore Misc.

Assignee:

Laszlo Gombos <laszlo.gombos>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aboxhall, allan.jensen, apinheiro, benjamin, buildbot, bunhere, cdumez, cfleizach, cmarcelo, commit-queue, dbates, dmazzoni, esprehn+autocc, glenn, gyuyoung.kim, jcraig, jdiggs, kondapallykalyan, macpherson, mario, menard, mitz, rakuco, rniwa, samuel_white, sergio, zalan

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
1st try	none
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2	none

Laszlo Gombos

Reported 2014-06-24 22:48:42 PDT

It seems that ENABLE(PROGRESS_ELEMENT) is set to 1 for all ports by default. Also I do not see why anyone would want to disable this feature as it is very mature. I propose to remove the build flag.

Attachments
1st try (77.30 KB, patch) 2014-06-24 23:04 PDT, Laszlo Gombos	no flags	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2 (622.30 KB, application/zip) 2014-06-25 00:40 PDT, Build Bot	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Laszlo Gombos

Comment 1 2014-06-24 23:04:26 PDT

Created attachment 233791 [details] 1st try

Benjamin Poulain

Comment 2 2014-06-24 23:22:00 PDT

Comment on attachment 233791 [details] 1st try Go for it, that's a good idea.

Build Bot

Comment 3 2014-06-25 00:39:53 PDT

Comment on attachment 233791 [details] 1st try Attachment 233791 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5818197857009664 New failing tests: media/W3C/video/networkState/networkState_during_loadstart.html

Build Bot

Comment 4 2014-06-25 00:40:00 PDT

Created attachment 233797 [details] Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-13 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5

Laszlo Gombos

Comment 5 2014-06-25 04:33:27 PDT

Comment on attachment 233791 [details] 1st try The failure seems to be an independent issue (Process failed to become responsive before timing out), lets try again..

WebKit Commit Bot

Comment 6 2014-06-25 05:05:09 PDT

Comment on attachment 233791 [details] 1st try Clearing flags on attachment: 233791 Committed r170425: <http://trac.webkit.org/changeset/170425>

WebKit Commit Bot

Comment 7 2014-06-25 05:05:17 PDT

All reviewed patches have been landed. Closing bug.

mitz

Comment 8 2014-06-25 09:16:36 PDT

(In reply to comment #6) > (From update of attachment 233791 [details]) > Clearing flags on attachment: 233791 > > Committed r170425: <http://trac.webkit.org/changeset/170425> This broke the iOS build.

alan

Comment 9 2014-06-25 10:02:25 PDT

(In reply to comment #8) > (In reply to comment #6) > > (From update of attachment 233791 [details] [details]) > > Clearing flags on attachment: 233791 > > > > Committed r170425: <http://trac.webkit.org/changeset/170425> > > This broke the iOS build. http://trac.webkit.org/changeset/170430

Note You need to log in before you can comment on or make changes to this bug.