Bug 134272

Summary:

Tiles on bottom of screen are not always allocated when necessary

Product:

WebKit

Reporter:

Myles C. Maxfield <mmaxfield>

Component:

New Bugs

Assignee:

Myles C. Maxfield <mmaxfield>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bunhere, cdumez, commit-queue, dino, esprehn+autocc, glenn, gyuyoung.kim, joepeck, jonlee, kondapallykalyan, rniwa, sergio, simon.fraser, thorton, webkit-bug-importer

Priority:

P2

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	simon.fraser: review+

Myles C. Maxfield

Reported 2014-06-24 15:00:28 PDT

Tiles on bottom of screen are not always allocated when necessary

Attachments
Patch (3.30 KB, patch) 2014-06-24 15:08 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (6.25 KB, patch) 2014-06-24 16:25 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (6.98 KB, patch) 2014-06-25 19:14 PDT, Myles C. Maxfield	simon.fraser: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Myles C. Maxfield

Comment 1 2014-06-24 15:08:26 PDT

Created attachment 233749 [details] Patch

Myles C. Maxfield

Comment 2 2014-06-24 15:09:32 PDT

<rdar://problem/16976937>

Myles C. Maxfield

Comment 3 2014-06-24 15:14:04 PDT

Comment on attachment 233749 [details] Patch Broke all the tests!

Myles C. Maxfield

Comment 4 2014-06-24 15:24:16 PDT

Comment on attachment 233749 [details] Patch No tests

Myles C. Maxfield

Comment 5 2014-06-24 16:25:17 PDT

Created attachment 233761 [details] Patch

Myles C. Maxfield

Comment 6 2014-06-24 18:26:07 PDT

http://trac.webkit.org/changeset/170414

Ryosuke Niwa

Comment 7 2014-06-24 20:06:44 PDT

Looks like the test added by this patch is failing on some bots: http://build.webkit.org/results/Apple%20Mavericks%20Release%20WK2%20(Tests)/r170415%20(6597)/compositing/visible-rect/iframe-no-layers-pretty-diff.html

Ryosuke Niwa

Comment 8 2014-06-24 20:06:59 PDT

http://build.webkit.org/results/Apple%20MountainLion%20Release%20WK2%20(Tests)/r170415%20(19320)/compositing/visible-rect/iframe-no-layers-pretty-diff.html

WebKit Commit Bot

Comment 9 2014-06-24 21:26:06 PDT

Re-opened since this is blocked by bug 134291

Ryosuke Niwa

Comment 10 2014-06-24 21:28:18 PDT

Sorry, I can't figure out what the right fix is because I don't know the context so I'm rolling out the patch for now.

Joseph Pecoraro

Comment 11 2014-06-25 17:53:26 PDT

This was rolled out in <http://trac.webkit.org/changeset/170417>

Myles C. Maxfield

Comment 12 2014-06-25 19:14:24 PDT

Created attachment 233862 [details] Patch

Myles C. Maxfield

Comment 13 2014-06-30 14:22:19 PDT

http://trac.webkit.org/changeset/170597

Note You need to log in before you can comment on or make changes to this bug.