| Summary: | Add long-press links gesture to Mac | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Peyton Randolph <prandolph> | ||||||||
| Component: | UI Events | Assignee: | Nobody <webkit-unassigned> | ||||||||
| Status: | RESOLVED WONTFIX | ||||||||||
| Severity: | Enhancement | CC: | bdakin, bfulgham, bunhere, cdumez, commit-queue, enrica, gyuyoung.kim, prandolph, sam, sergio, simon.fraser, thorton | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Mac | ||||||||||
| OS: | Other | ||||||||||
| Bug Depends on: | 134612 | ||||||||||
| Bug Blocks: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
Peyton Randolph
2014-06-24 12:35:53 PDT
Created attachment 233986 [details]
Feature flag
Created attachment 234003 [details]
Feature flag
Comment on attachment 234003 [details] Feature flag Clearing flags on attachment: 234003 Committed r170550: <http://trac.webkit.org/changeset/170550> All reviewed patches have been landed. Closing bug. More patches coming. Why is this 10.10 only? Does it require new AppKit API? (In reply to comment #6) > Why is this 10.10 only? Does it require new AppKit API? I made it 10.10-only because the Safari-land feature it's supporting needs 10.10. But there's no technical reason to require 10.10 on the WebKit side, so if we'd like, we could enable it for 10.8 and 10.9. (In reply to comment #7) > (In reply to comment #6) > > Why is this 10.10 only? Does it require new AppKit API? > > I made it 10.10-only because the Safari-land feature it's supporting needs 10.10. But there's no technical reason to require 10.10 on the WebKit side, so if we'd like, we could enable it for 10.8 and 10.9. Yes. Please enable everywhere. (In reply to comment #8) > (In reply to comment #7) > > (In reply to comment #6) > > > Why is this 10.10 only? Does it require new AppKit API? > > > > I made it 10.10-only because the Safari-land feature it's supporting needs 10.10. But there's no technical reason to require 10.10 on the WebKit side, so if we'd like, we could enable it for 10.8 and 10.9. > > Yes. Please enable everywhere. Everywhere Mac or everywhere everywhere? Comment on attachment 234003 [details] Feature flag Committed r170550. Created attachment 234101 [details]
Event handling
Comment on attachment 234101 [details] Event handling View in context: https://bugs.webkit.org/attachment.cgi?id=234101&action=review Will cc some relevant people. > Source/WebCore/ChangeLog:3 > + Add link long-press event handling using a timer. we usually use one bug per patch. this bug already landed a patch :) might want to adjust the titles a bit (In reply to comment #12) > (From update of attachment 234101 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=234101&action=review > > Will cc some relevant people. > > > Source/WebCore/ChangeLog:3 > > + Add link long-press event handling using a timer. > > we usually use one bug per patch. this bug already landed a patch :) might want to adjust the titles a bit Sure thing. (In reply to comment #13) > (In reply to comment #12) > > (From update of attachment 234101 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=234101&action=review > > > > Will cc some relevant people. > > > > > Source/WebCore/ChangeLog:3 > > > + Add link long-press event handling using a timer. > > > > we usually use one bug per patch. this bug already landed a patch :) might want to adjust the titles a bit > > Sure thing. Created a bug to track this subtask: https://bugs.webkit.org/show_bug.cgi?id=134612 Superseded by https://bugs.webkit.org/show_bug.cgi?id=135257 |