Bug 134262

Summary:

Add long-press links gesture to Mac

Product:

WebKit

Reporter:

Peyton Randolph <prandolph>

Component:

UI Events

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED WONTFIX

Severity:

Enhancement

CC:

bdakin, bfulgham, bunhere, cdumez, commit-queue, enrica, gyuyoung.kim, prandolph, sam, sergio, simon.fraser, thorton

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

Other

Bug Depends on:

134612

Bug Blocks:

Attachments:

Description	Flags
Feature flag	none
Feature flag	none
Event handling	none

Peyton Randolph

Reported 2014-06-24 12:35:53 PDT

Mac Safari would like a long-press gesture for links. Long-pressing on a link would send metadata, like the link's URL, title, and position, up to Safari.

Attachments
Feature flag (31.59 KB, patch) 2014-06-27 09:16 PDT, Peyton Randolph	no flags	Details Formatted Diff Diff
Feature flag (31.41 KB, patch) 2014-06-27 12:11 PDT, Peyton Randolph	no flags	Details Formatted Diff Diff
Event handling (14.03 KB, patch) 2014-06-30 15:14 PDT, Peyton Randolph	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Peyton Randolph

Comment 1 2014-06-27 09:16:01 PDT

Created attachment 233986 [details] Feature flag

Peyton Randolph

Comment 2 2014-06-27 12:11:34 PDT

Created attachment 234003 [details] Feature flag

WebKit Commit Bot

Comment 3 2014-06-27 13:47:31 PDT

Comment on attachment 234003 [details] Feature flag Clearing flags on attachment: 234003 Committed r170550: <http://trac.webkit.org/changeset/170550>

WebKit Commit Bot

Comment 4 2014-06-27 13:47:35 PDT

All reviewed patches have been landed. Closing bug.

Peyton Randolph

Comment 5 2014-06-27 15:45:52 PDT

More patches coming.

Sam Weinig

Comment 6 2014-06-27 17:28:40 PDT

Why is this 10.10 only? Does it require new AppKit API?

Peyton Randolph

Comment 7 2014-06-27 23:06:08 PDT

(In reply to comment #6) > Why is this 10.10 only? Does it require new AppKit API? I made it 10.10-only because the Safari-land feature it's supporting needs 10.10. But there's no technical reason to require 10.10 on the WebKit side, so if we'd like, we could enable it for 10.8 and 10.9.

Sam Weinig

Comment 8 2014-06-28 17:24:27 PDT

(In reply to comment #7) > (In reply to comment #6) > > Why is this 10.10 only? Does it require new AppKit API? > > I made it 10.10-only because the Safari-land feature it's supporting needs 10.10. But there's no technical reason to require 10.10 on the WebKit side, so if we'd like, we could enable it for 10.8 and 10.9. Yes. Please enable everywhere.

Peyton Randolph

Comment 9 2014-06-30 15:07:47 PDT

(In reply to comment #8) > (In reply to comment #7) > > (In reply to comment #6) > > > Why is this 10.10 only? Does it require new AppKit API? > > > > I made it 10.10-only because the Safari-land feature it's supporting needs 10.10. But there's no technical reason to require 10.10 on the WebKit side, so if we'd like, we could enable it for 10.8 and 10.9. > > Yes. Please enable everywhere. Everywhere Mac or everywhere everywhere?

Peyton Randolph

Comment 10 2014-06-30 15:09:04 PDT

Comment on attachment 234003 [details] Feature flag Committed r170550.

Peyton Randolph

Comment 11 2014-06-30 15:14:40 PDT

Created attachment 234101 [details] Event handling

Tim Horton

Comment 12 2014-07-03 15:03:08 PDT

Comment on attachment 234101 [details] Event handling View in context: https://bugs.webkit.org/attachment.cgi?id=234101&action=review Will cc some relevant people. > Source/WebCore/ChangeLog:3 > + Add link long-press event handling using a timer. we usually use one bug per patch. this bug already landed a patch :) might want to adjust the titles a bit

Peyton Randolph

Comment 13 2014-07-03 15:11:57 PDT

(In reply to comment #12) > (From update of attachment 234101 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=234101&action=review > > Will cc some relevant people. > > > Source/WebCore/ChangeLog:3 > > + Add link long-press event handling using a timer. > > we usually use one bug per patch. this bug already landed a patch :) might want to adjust the titles a bit Sure thing.

Peyton Randolph

Comment 14 2014-07-03 15:12:47 PDT

(In reply to comment #13) > (In reply to comment #12) > > (From update of attachment 234101 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=234101&action=review > > > > Will cc some relevant people. > > > > > Source/WebCore/ChangeLog:3 > > > + Add link long-press event handling using a timer. > > > > we usually use one bug per patch. this bug already landed a patch :) might want to adjust the titles a bit > > Sure thing. Created a bug to track this subtask: https://bugs.webkit.org/show_bug.cgi?id=134612

Peyton Randolph

Comment 15 2014-07-24 14:35:37 PDT

Superseded by https://bugs.webkit.org/show_bug.cgi?id=135257

Note You need to log in before you can comment on or make changes to this bug.