Bug 13426

Summary:

NPObject should be forward declared using 'struct' instead of 'class'

Product:

WebKit

Reporter:

Darin Fisher (:fishd, Google) <fishd>

Component:

WebKit Misc.

Assignee:

Darin Fisher (:fishd, Google) <fishd>

Status:

RESOLVED FIXED

Severity:

Minor

Priority:

Version:

523.x (Safari 3)

Hardware:

All

OS:

All

Attachments:

Description	Flags
trivial patch	aroben: review+

Darin Fisher (:fishd, Google)

Reported 2007-04-20 19:03:46 PDT

NPObject should be forward declared using 'struct' instead of 'class' Frame.h has 'class NPObject;' which causes strict compilers to complain if npruntime.h is also included in the same compilation unit as Frame.h.

Attachments
trivial patch (754 bytes, patch) 2007-04-20 19:04 PDT, Darin Fisher (:fishd, Google)	aroben: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Darin Fisher (:fishd, Google)

Comment 1 2007-04-20 19:04:42 PDT

Created attachment 14118 [details] trivial patch

Adam Roben (:aroben)

Comment 2 2007-04-20 19:06:32 PDT

Comment on attachment 14118 [details] trivial patch r=me

Mark Rowe (bdash)

Comment 3 2007-04-21 01:28:20 PDT

Landed in r20990.

Note You need to log in before you can comment on or make changes to this bug.