Summary: | Enable GAMEPAD in the Mac build, disabled at runtime | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brady Eidson <beidson> | ||||||||||||
Component: | WebCore Misc. | Assignee: | Brady Eidson <beidson> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | bunhere, cdumez, cgarcia, commit-queue, dino, esprehn+autocc, gyuyoung.kim, kondapallykalyan, mhahnenberg, sergio, syoichi, timothy | ||||||||||||
Priority: | P2 | ||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||
Hardware: | Mac | ||||||||||||||
OS: | All | ||||||||||||||
Bug Depends on: | |||||||||||||||
Bug Blocks: | 134076 | ||||||||||||||
Attachments: |
|
Description
Brady Eidson
2014-06-24 11:04:16 PDT
Created attachment 233718 [details]
Patch v1
Created attachment 233719 [details]
Patch v2 - Without the Shader.h change (why is it even in there?)
Removed Shader.h from the project file once-and-for-all in 170374 Created attachment 233728 [details]
Patch v3 - Better feature defines (mac-only)
Created attachment 233736 [details]
Patch v3 (take 2) - Same patch again, but EWSs should be in better shape now.
Comment on attachment 233736 [details]
Patch v3 (take 2) - Same patch again, but EWSs should be in better shape now.
Seems to still be some compile errors on other ports.
Will figure out EWS on other ports before landing. Windows, at least, is not related - that EWS is just hosed. NM, quite real compile errors. will fix. Created attachment 233750 [details]
Patch for landing v1
The additional bindings code needed #if ENABLE() guards
If this passes EWS we're good.
Comment on attachment 233750 [details] Patch for landing v1 Clearing flags on attachment: 233750 Committed r170400: <http://trac.webkit.org/changeset/170400> All reviewed patches have been landed. Closing bug. |