|Summary:||Enable GAMEPAD in the Mac build, disabled at runtime|
|Product:||WebKit||Reporter:||Brady Eidson <beidson>|
|Component:||WebCore Misc.||Assignee:||Brady Eidson <beidson>|
|Severity:||Normal||CC:||bunhere, cdumez, cgarcia, commit-queue, dino, esprehn+autocc, gyuyoung.kim, kondapallykalyan, mhahnenberg, sergio, syoichi, timothy|
|Version:||528+ (Nightly build)|
|Bug Depends on:|
Description Brady Eidson 2014-06-24 11:04:16 PDT
Enable GAMEPAD in the Mac build but disabled at runtime. This will help with patches coming soon by allowing EWS/commit queue to see build failures. It will also be nice to not have to enable it locally after an update, always causing a full rebuild.
Comment 2 Brady Eidson 2014-06-24 11:14:26 PDT
Created attachment 233719 [details] Patch v2 - Without the Shader.h change (why is it even in there?)
Comment 3 Brady Eidson 2014-06-24 11:24:19 PDT
Removed Shader.h from the project file once-and-for-all in 170374
Comment 4 Brady Eidson 2014-06-24 12:07:55 PDT
Created attachment 233728 [details] Patch v3 - Better feature defines (mac-only)
Comment 5 Brady Eidson 2014-06-24 13:45:23 PDT
Created attachment 233736 [details] Patch v3 (take 2) - Same patch again, but EWSs should be in better shape now.
Comment 6 Dean Jackson 2014-06-24 14:42:27 PDT
Comment on attachment 233736 [details] Patch v3 (take 2) - Same patch again, but EWSs should be in better shape now. Seems to still be some compile errors on other ports.
Comment 7 Brady Eidson 2014-06-24 14:47:31 PDT
Will figure out EWS on other ports before landing. Windows, at least, is not related - that EWS is just hosed.
Comment 8 Brady Eidson 2014-06-24 14:49:53 PDT
NM, quite real compile errors. will fix.
Comment 9 Brady Eidson 2014-06-24 15:16:19 PDT
Created attachment 233750 [details] Patch for landing v1 The additional bindings code needed #if ENABLE() guards If this passes EWS we're good.
Comment 10 WebKit Commit Bot 2014-06-24 16:17:50 PDT
Comment on attachment 233750 [details] Patch for landing v1 Clearing flags on attachment: 233750 Committed r170400: <http://trac.webkit.org/changeset/170400>
Comment 11 WebKit Commit Bot 2014-06-24 16:17:58 PDT
All reviewed patches have been landed. Closing bug.