Bug 134248

Summary: Only flush layers when the exposed rect actually changes
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ahmad.saleem792, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch andersca: review+

Antti Koivisto
Reported 2014-06-24 06:46:07 PDT
Currently we flush unconditionally.
Attachments
patch (2.57 KB, patch)
2014-06-24 06:56 PDT, Antti Koivisto 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2014-06-24 06:56:47 PDT
Created attachment 233698 [details] patch
Simon Fraser (smfr)
Comment 2 2014-06-24 08:56:57 PDT
Comment on attachment 233698 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=233698&action=review > Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:206 > + auto rect = enclosingIntRect(exposedContentRect); > + if (frameView->exposedContentRect() == rect) > + return; This makes assumptions about how FrameView does rounding. Maybe setExposedContentRect() should instead return a bool?
Antti Koivisto
Comment 3 2014-06-24 12:10:48 PDT
http://trac.webkit.org/changeset/170377
Antti Koivisto
Comment 4 2014-06-24 12:16:12 PDT
> This makes assumptions about how FrameView does rounding. Maybe setExposedContentRect() should instead return a bool? There is currently no rounding (these were just switched to FloatRect) and it is generally reasonable to expect getters and setters to pair. The setter should probably be renamed if it starts rounding.
Ahmad Saleem
Comment 5 2022-10-10 15:13:28 PDT
Landed and didn't backed out: https://github.com/WebKit/WebKit/commit/80d3862733cf0b06bde7cde3af207aa5f5e4518b Marking this as "RESOLVED FIXED".
Radar WebKit Bug Importer
Comment 6 2022-10-10 15:14:18 PDT
<rdar://problem/100999725>
Note You need to log in before you can comment on or make changes to this bug.