Summary: | Reduce synchronous layout triggered by JavaScript-based media controls | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||
Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | calvaris, commit-queue, dino, eric.carlson, glenn, jer.noble, kling, philipj, sergio | ||||
Priority: | P2 | ||||||
Version: | 412.x | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Joseph Pecoraro
2014-06-23 12:36:25 PDT
Created attachment 233628 [details]
[PATCH] Proposed Fix
Based on measurements from Andreas this improved PLT by ~0.5%. It reduces the number of calls to offsetWidth from 8 to 3 when just loading a page with a video and controls.
I see one possible issue with this patch, if the media element itself changes size the cached values may be wrong. That is because the timeline is flex based and we do not know when the element itself changed size. So that may be a regression that could be addressed later.
Comment on attachment 233628 [details] [PATCH] Proposed Fix Clearing flags on attachment: 233628 Committed r170315: <http://trac.webkit.org/changeset/170315> All reviewed patches have been landed. Closing bug. |