Bug 134206

Summary: Ensure that we always use symlink free paths when specifying cache directories
Product: WebKit Reporter: Oliver Hunt <oliver>
Component: New BugsAssignee: Oliver Hunt <oliver>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch andersca: review+

Oliver Hunt
Reported 2014-06-23 12:08:41 PDT
Ensure that we always use symlink free paths when specifying cache directories
Attachments
Patch (5.49 KB, patch)
2014-06-23 12:11 PDT, Oliver Hunt 		no flags
DetailsFormatted DiffDiff
Patch (6.65 KB, patch)
2014-06-23 12:40 PDT, Oliver Hunt 		andersca: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Oliver Hunt
Comment 1 2014-06-23 12:11:34 PDT
Created attachment 233622 [details] Patch
Sam Weinig
Comment 2 2014-06-23 12:24:16 PDT
Can this reuse any of the functionality already in SandboxInitializationParameters?
Oliver Hunt
Comment 3 2014-06-23 12:40:12 PDT
Created attachment 233627 [details] Patch
Oliver Hunt
Comment 4 2014-06-23 12:48:03 PDT
(In reply to comment #2) > Can this reuse any of the functionality already in SandboxInitializationParameters? How about this?
Sam Weinig
Comment 5 2014-06-23 13:25:11 PDT
(In reply to comment #4) > (In reply to comment #2) > > Can this reuse any of the functionality already in SandboxInitializationParameters? > How about this? Is this does realpathing now? Once in the UIProcess, again in the WebProcess?
Sam Weinig
Comment 6 2014-06-23 13:25:21 PDT
(In reply to comment #5) > (In reply to comment #4) > > (In reply to comment #2) > > > Can this reuse any of the functionality already in SandboxInitializationParameters? > > How about this? > > Is this does realpathing now? Once in the UIProcess, again in the WebProcess? s/does/double/
Oliver Hunt
Comment 7 2014-06-23 13:27:53 PDT
Committed r170313: <http://trac.webkit.org/changeset/170313>
Alexey Proskuryakov
Comment 8 2014-06-24 00:35:48 PDT
I don't really understand what this achieves. Would be nice to have a more clear rationale before r+'ing. See also <rdar://problem/14062743>.
Note You need to log in before you can comment on or make changes to this bug.