Bug 134206

Summary:

Ensure that we always use symlink free paths when specifying cache directories

Product:

WebKit

Reporter:

Oliver Hunt <oliver>

Component:

New Bugs

Assignee:

Oliver Hunt <oliver>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, sam

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	andersca: review+

Description Oliver Hunt 2014-06-23 12:08:41 PDT

Ensure that we always use symlink free paths when specifying cache directories

Comment 1 Oliver Hunt 2014-06-23 12:11:34 PDT

Created attachment 233622 [details]
Patch

Comment 2 Sam Weinig 2014-06-23 12:24:16 PDT

Can this reuse any of the functionality already in SandboxInitializationParameters?

Comment 3 Oliver Hunt 2014-06-23 12:40:12 PDT

Created attachment 233627 [details]
Patch

Comment 4 Oliver Hunt 2014-06-23 12:48:03 PDT

(In reply to comment #2)
> Can this reuse any of the functionality already in SandboxInitializationParameters?
How about this?

Comment 5 Sam Weinig 2014-06-23 13:25:11 PDT

(In reply to comment #4)
> (In reply to comment #2)
> > Can this reuse any of the functionality already in SandboxInitializationParameters?
> How about this?

Is this does realpathing now? Once in the UIProcess, again in the WebProcess?

Comment 6 Sam Weinig 2014-06-23 13:25:21 PDT

(In reply to comment #5)
> (In reply to comment #4)
> > (In reply to comment #2)
> > > Can this reuse any of the functionality already in SandboxInitializationParameters?
> > How about this?
> 
> Is this does realpathing now? Once in the UIProcess, again in the WebProcess?

s/does/double/

Comment 7 Oliver Hunt 2014-06-23 13:27:53 PDT

Committed r170313: <http://trac.webkit.org/changeset/170313>

Comment 8 Alexey Proskuryakov 2014-06-24 00:35:48 PDT

I don't really understand what this achieves. Would be nice to have a more clear rationale before r+'ing.

See also <rdar://problem/14062743>.