Bug 134205

Summary: Fix build when USER_MESSAGE_HANDLERS is enabled
Product: WebKit Reporter: Adrian Perez <aperez>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED INVALID    
Severity: Normal CC: andersca, commit-queue, darin, fpizlo, mhahnenberg, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch fpizlo: review+, commit-queue: commit-queue-

Adrian Perez
Reported 2014-06-23 12:01:27 PDT
Fix build when USER_MESSAGE_HANDLERS is enabled
Attachments
Patch (1.26 KB, patch)
2014-06-23 12:23 PDT, Adrian Perez 		fpizlo: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adrian Perez
Comment 1 2014-06-23 12:23:04 PDT
Created attachment 233625 [details] Patch
WebKit Commit Bot
Comment 2 2014-06-23 13:12:11 PDT
Comment on attachment 233625 [details] Patch Rejecting attachment 233625 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'build', '--no-clean', '--no-update', '--build-style=release', '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: -c /Volumes/Data/EWS/WebKit/WebKitBuild/Release/DerivedSources/WebCore/JSEntityReference.cpp -o /Volumes/Data/EWS/WebKit/WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/x86_64/JSEntityReference.o ** BUILD FAILED ** The following build commands failed: CompileC /Volumes/Data/EWS/WebKit/WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/x86_64/JSDOMWindowBase.o bindings/js/JSDOMWindowBase.cpp normal x86_64 c++ com.apple.compilers.llvm.clang.1_0.compiler (1 failure) Full output: http://webkit-queues.appspot.com/results/6003043048882176
Adrian Perez
Comment 3 2014-06-25 09:42:11 PDT
Okay, my bad, JSWebKitNamespace.{h,cpp} are derived sources which should be generated during the build. What we really need to do is generate those for the GTK port. Closing the bug, as it is not really a bug. Sorry for the noise!
Note You need to log in before you can comment on or make changes to this bug.