[Cocoa] No way to grant storage quotas for WebSQL

• Component: WebKit2
• Status: RESOLVED FIXED

[Cocoa] No way to grant storage quotas for WebSQL

Created attachment 233572 [details]
Add WKUIDelegatePrivate method for increasing quota

Comment on attachment 233572 [details]
Add WKUIDelegatePrivate method for increasing quota

I think this can be done with a completion handler.

[Anders Carlsson]

Comment on attachment 233572 [details]
Add WKUIDelegatePrivate method for increasing quota

View in context: https://bugs.webkit.org/attachment.cgi?id=233572&action=review

> Source/WebKit2/UIProcess/API/Cocoa/_WKSecurityOrigin.h:36
> +@property (nonatomic, readonly) NSString *protocol;
> +@property (nonatomic, readonly) NSString *host;

These should be copy.

Created attachment 233575 [details]
Add WKUIDelegatePrivate method for increasing quota

[WebKit Commit Bot]

Attachment 233575 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:4451:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.h:65:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:176:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:190:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/API/APIUIClient.h:113:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/API/C/WKPage.cpp:1441:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 6 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Anders Carlsson]

Comment on attachment 233575 [details]
Add WKUIDelegatePrivate method for increasing quota

View in context: https://bugs.webkit.org/attachment.cgi?id=233575&action=review

> Source/WebKit2/UIProcess/API/Cocoa/_WKSecurityOrigin.mm:48
> +    _origin = origin;

Since WebCore security origins are mutable, I think it's safer if we copy it here.

Fixed in <http://trac.webkit.org/r170303>.