Bug 134166

Summary: Implement the rest of back forward tree decoding
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: mitz
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch sam: review+

Anders Carlsson
Reported 2014-06-21 16:00:14 PDT
Implement the rest of back forward tree decoding
Attachments
Patch (3.95 KB, patch)
2014-06-21 16:00 PDT, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Patch (3.84 KB, patch)
2014-06-21 16:23 PDT, Anders Carlsson 		sam: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2014-06-21 16:00:42 PDT
Created attachment 233549 [details] Patch
mitz
Comment 2 2014-06-21 16:17:35 PDT
Comment on attachment 233549 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=233549&action=review > Source/WebKit2/UIProcess/mac/LegacySessionStateCoding.cpp:442 > + break; ?
Anders Carlsson
Comment 3 2014-06-21 16:23:27 PDT
Created attachment 233550 [details] Patch
Sam Weinig
Comment 4 2014-06-21 16:27:01 PDT
Comment on attachment 233550 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=233550&action=review > Source/WebKit2/UIProcess/mac/LegacySessionStateCoding.cpp:445 > + decoder >> formDataElement.fileStart; > + if (formDataElement.fileStart < 0) > + return; Is formDataElement.fileStart < 0 ever ok? Should this mark the decoder as invalid? > Source/WebKit2/UIProcess/mac/LegacySessionStateCoding.cpp:490 > + bool dummy; > + decoder >> dummy; Can you add a comment for future versions of us about what this once was.
Anders Carlsson
Comment 5 2014-06-22 09:34:40 PDT
Committed r170262: <http://trac.webkit.org/changeset/170262>
Note You need to log in before you can comment on or make changes to this bug.