Bug 134166

Summary:

Implement the rest of back forward tree decoding

Product:

WebKit

Reporter:

Anders Carlsson <andersca>

Component:

New Bugs

Assignee:

Anders Carlsson <andersca>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

mitz

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	sam: review+

Description Anders Carlsson 2014-06-21 16:00:14 PDT

Implement the rest of back forward tree decoding

Comment 1 Anders Carlsson 2014-06-21 16:00:42 PDT

Created attachment 233549 [details]
Patch

Comment 2 mitz 2014-06-21 16:17:35 PDT

Comment on attachment 233549 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=233549&action=review

> Source/WebKit2/UIProcess/mac/LegacySessionStateCoding.cpp:442
> +        break;

?

Comment 3 Anders Carlsson 2014-06-21 16:23:27 PDT

Created attachment 233550 [details]
Patch

Comment 4 Sam Weinig 2014-06-21 16:27:01 PDT

Comment on attachment 233550 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=233550&action=review

> Source/WebKit2/UIProcess/mac/LegacySessionStateCoding.cpp:445
> +        decoder >> formDataElement.fileStart;
> +        if (formDataElement.fileStart < 0)
> +            return;

Is formDataElement.fileStart < 0 ever ok? Should this mark the decoder as invalid?

> Source/WebKit2/UIProcess/mac/LegacySessionStateCoding.cpp:490
> +    bool dummy;
> +    decoder >> dummy;

Can you add a comment for future versions of us about what this once was.

Comment 5 Anders Carlsson 2014-06-22 09:34:40 PDT

Committed r170262: <http://trac.webkit.org/changeset/170262>