Bug 134140

Summary: Support for-in in the FTL
Product: WebKit Reporter: Mark Hahnenberg <mhahnenberg>
Component: JavaScriptCoreAssignee: Mark Hahnenberg <mhahnenberg>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 134141    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
fpizlo: review+
benchmark results none

Mark Hahnenberg
Reported 2014-06-20 15:53:50 PDT
Currently we only support the for-in construct in the LLInt and baseline JIT. We should add support for for-in to the DFG and FTL.
Attachments
Patch (18.98 KB, patch)
2014-07-28 17:16 PDT, Mark Hahnenberg 		no flags
DetailsFormatted DiffDiff
Patch (19.23 KB, patch)
2014-07-28 17:47 PDT, Mark Hahnenberg 		no flags
DetailsFormatted DiffDiff
Patch (19.47 KB, patch)
2014-07-28 18:16 PDT, Mark Hahnenberg 		fpizlo: review+
DetailsFormatted DiffDiff
benchmark results (44.30 KB, text/plain)
2014-07-29 11:00 PDT, Mark Hahnenberg 		no flags
Details
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Mark Hahnenberg
Comment 1 2014-07-28 17:16:26 PDT
Created attachment 235649 [details] Patch
Mark Hahnenberg
Comment 2 2014-07-28 17:16:50 PDT
(In reply to comment #1) > Created an attachment (id=235649) [details] > Patch Initial cut. Still running perf tests.
Mark Hahnenberg
Comment 3 2014-07-28 17:28:01 PDT
(In reply to comment #2) > (In reply to comment #1) > > Created an attachment (id=235649) [details] [details] > > Patch > > Initial cut. Still running perf tests. Still a few bugs lurking.
Mark Hahnenberg
Comment 4 2014-07-28 17:47:01 PDT
Created attachment 235653 [details] Patch
Mark Hahnenberg
Comment 5 2014-07-28 18:16:24 PDT
Created attachment 235655 [details] Patch
Mark Hahnenberg
Comment 6 2014-07-29 11:00:59 PDT
Created attachment 235696 [details] benchmark results
Filip Pizlo
Comment 7 2014-07-29 13:32:52 PDT
Comment on attachment 235655 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=235655&action=review > Source/JavaScriptCore/ftl/FTLAbstractHeapRepository.h:79 > + macro(Structure_structureID, Structure::structureIDOffset()) \ > + macro(JSPropertyNameEnumerator_cachedStructureID, JSPropertyNameEnumerator::cachedStructureIDOffset()) \ > + macro(JSPropertyNameEnumerator_cachedInlineCapacity, JSPropertyNameEnumerator::cachedInlineCapacityOffset()) \ > + macro(JSPropertyNameEnumerator_cachedPropertyNamesLength, JSPropertyNameEnumerator::cachedPropertyNamesLengthOffset()) \ > + macro(JSPropertyNameEnumerator_cachedPropertyNamesVector, JSPropertyNameEnumerator::cachedPropertyNamesVectorOffset()) Sort in alphabetical order.
Mark Hahnenberg
Comment 8 2014-07-29 15:44:37 PDT
Landed in http://trac.webkit.org/changeset/171763
Note You need to log in before you can comment on or make changes to this bug.