Bug 134135

Summary: [Mac] Margins for new form controls need tweaking
Product: WebKit Reporter: Dean Jackson <dino>
Component: New BugsAssignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, ossy, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 134155    
Bug Blocks:    
Attachments:
Description Flags
Patch
sam: review+, buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion none

Dean Jackson
Reported 2014-06-20 15:34:02 PDT
[Mac] Margins for new form controls need tweaking
Attachments
Patch (4.47 KB, patch)
2014-06-20 15:38 PDT, Dean Jackson 		sam: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion (2.04 MB, application/zip)
2014-06-20 19:05 PDT, Build Bot 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Dean Jackson
Comment 1 2014-06-20 15:38:49 PDT
Created attachment 233471 [details] Patch
Dean Jackson
Comment 2 2014-06-20 15:40:18 PDT
Errrr.... I need to boot into Mavericks again to produce rebaselined test results which involve checkboxes or form controls.
Dean Jackson
Comment 3 2014-06-20 15:40:45 PDT
About 20 tests will need new results.
Build Bot
Comment 4 2014-06-20 19:05:05 PDT
Comment on attachment 233471 [details] Patch Attachment 233471 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5598356734738432 New failing tests: fast/block/basic/011.html css2.1/t09-c5526c-display-00-e.html tables/mozilla_expected_failures/core/captions1.html http/tests/navigation/javascriptlink-frames.html fast/forms/form-element-geometry.html fast/inline/positionedLifetime.html tables/mozilla/bugs/bug1318.html fast/block/margin-collapse/103.html fast/forms/formmove.html tables/mozilla/bugs/bug4527.html fast/forms/box-shadow-override.html css1/box_properties/acid_test.html fast/replaced/width100percent-radio.html fast/forms/basic-inputs.html fast/forms/input-value.html fast/forms/input-appearance-height.html tables/mozilla_expected_failures/core/captions2.html fast/replaced/replaced-breaking.html fast/forms/formmove2.html
Build Bot
Comment 5 2014-06-20 19:05:06 PDT
Created attachment 233497 [details] Archive of layout-test-results from webkit-ews-03 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-03 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Dean Jackson
Comment 6 2014-06-20 20:11:15 PDT
<rdar://problem/17262164>
Dean Jackson
Comment 7 2014-06-20 20:11:31 PDT
Committed r170228: <http://trac.webkit.org/changeset/170228>
Csaba Osztrogonác
Comment 8 2014-06-21 01:55:45 PDT
(In reply to comment #7) > Committed r170228: <http://trac.webkit.org/changeset/170228> It made 9 tests fail on Apple Mountain Lion bots.
WebKit Commit Bot
Comment 9 2014-06-21 07:57:52 PDT
Re-opened since this is blocked by bug 134155
Dean Jackson
Comment 10 2014-06-21 16:58:42 PDT
Committed r170257: <http://trac.webkit.org/changeset/170257>
Alexey Proskuryakov
Comment 11 2014-06-22 23:30:21 PDT
This broke a regression test, see bug 134182.
Note You need to log in before you can comment on or make changes to this bug.