Bug 134133

Summary: [iOS] GSFontAddCGFont is deprecated and we use it in DumpRenderTree
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: bunhere, cdumez, commit-queue, dino, gyuyoung.kim, jonlee, sergio, simonjam, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch simon.fraser: review+

Description Myles C. Maxfield 2014-06-20 15:31:00 PDT
GSFontAddCGFont is deprecated and we use it in DumpRenderTree
Comment 1 Myles C. Maxfield 2014-06-20 15:37:53 PDT
Created attachment 233470 [details]
Patch
Comment 2 Myles C. Maxfield 2014-06-22 11:34:03 PDT
CTFontManagerRegisterGraphicsFont is preferable.
Comment 3 Myles C. Maxfield 2014-06-30 13:01:32 PDT
Created attachment 234088 [details]
Patch
Comment 4 Simon Fraser (smfr) 2014-06-30 13:27:25 PDT
Comment on attachment 234088 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=234088&action=review

> Tools/DumpRenderTree/mac/DumpRenderTree.mm:535
>          fprintf(stderr, "Failed to add CGFont to GraphicsServices for the %s font.\n", sectionName.c_str());

Shouldn't this print error details?
Comment 5 Myles C. Maxfield 2014-06-30 13:28:16 PDT
Comment on attachment 234088 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=234088&action=review

>> Tools/DumpRenderTree/mac/DumpRenderTree.mm:535
>>          fprintf(stderr, "Failed to add CGFont to GraphicsServices for the %s font.\n", sectionName.c_str());
> 
> Shouldn't this print error details?

Can also remove GSFont header
Comment 6 Myles C. Maxfield 2014-06-30 17:46:27 PDT
http://trac.webkit.org/changeset/170623