Bug 134123

Summary:

AX: Remove tight platform expectation coupling form roles-exposed layout test.

Product:

WebKit

Reporter:

Samuel White <samuel_white>

Component:

Accessibility

Assignee:

Samuel White <samuel_white>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aboxhall, apinheiro, buildbot, bunhere, cdumez, cfleizach, commit-queue, dmazzoni, gyuyoung.kim, jcraig, jdiggs, mario, rniwa, sergio, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Mac (Intel)

OS:

OS X 10.9

Attachments:

Description	Flags
Patch.	cfleizach: review+, buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2	none
Patch.	none

Description Samuel White 2014-06-20 14:30:05 PDT

We have some platform specific expectations baked into the roles-exposed.html test that limit our ability to make changes downstream. These type of expectations should be validated via the roles-exposed-expected.txt text diffing (rather than explicit .js checks in the test itself) so we can make platform changes downstream.

Comment 1 Radar WebKit Bug Importer 2014-06-20 14:30:16 PDT

<rdar://problem/17401006>

Comment 2 Samuel White 2014-06-20 16:12:55 PDT

Created attachment 233477 [details]
Patch.

Comment 3 James Craig 2014-06-20 18:12:39 PDT

You might as well pull out the role conditional check and te role description expectations too, no?  It doesn’t make sense to have a PASS notice on the role if the subrole or role description are there but not being used. Just print out the actual results for each.

Comment 4 Build Bot 2014-06-20 18:50:37 PDT

Comment on attachment 233477 [details]
Patch.

Attachment 233477 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6302044176515072

New failing tests:
media/W3C/video/networkState/networkState_during_loadstart.html

Comment 5 Build Bot 2014-06-20 18:50:40 PDT

Created attachment 233496 [details]
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-10  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

Comment 6 Samuel White 2014-06-24 15:56:41 PDT

Created attachment 233756 [details]
Patch.

Removing the remaining platform specific information from the test itself and the PASS/FAIL output. Platform agnostic tests such as this one should rely on the text diffs to determine PASS/FAIL.

Comment 7 Samuel White 2014-06-24 16:01:41 PDT

(In reply to comment #3)
> You might as well pull out the role conditional check and te role description expectations too, no?  It doesn’t make sense to have a PASS notice on the role if the subrole or role description are there but not being used. Just print out the actual results for each.

Agreed. Done.

Comment 8 chris fleizach 2014-06-24 16:59:57 PDT

Comment on attachment 233756 [details]
Patch.

gtk will also need to be updated, so please monitor the gtk bot in order to land that result

Comment 9 WebKit Commit Bot 2014-06-24 17:56:42 PDT

Comment on attachment 233756 [details]
Patch.

Clearing flags on attachment: 233756

Committed r170412: <http://trac.webkit.org/changeset/170412>

Comment 10 WebKit Commit Bot 2014-06-24 17:56:48 PDT

All reviewed patches have been landed.  Closing bug.