[ftlopt] Fold GetById/PutById to MultiGetByOffset/GetByOffset or MultiPutByOffset/PutByOffset, which implies handling non-singleton sets

• Component: JavaScriptCore
• Status: RESOLVED FIXED

[Filip Pizlo]

Patch forthcoming.

[Filip Pizlo]

Created attachment 233404 [details]
work in progress

[Filip Pizlo]

Created attachment 233542 [details]
the patch

[Filip Pizlo]

Comment on attachment 233542 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=233542&action=review

> Source/JavaScriptCore/ChangeLog:111
> +        Reviewed by NOBODY (OOPS!).
> +        
> +        Work in progress.
> +
> +        * bytecode/GetByIdStatus.cpp:
> +        (JSC::GetByIdStatus::computeForStubInfo):
> +        (JSC::GetByIdStatus::computeFor):
> +        * bytecode/GetByIdStatus.h:
> +        * bytecode/PutByIdStatus.cpp:
> +        (JSC::PutByIdStatus::computeFor):
> +        * bytecode/PutByIdStatus.h:
> +        * bytecode/PutByIdVariant.h:
> +        (JSC::PutByIdVariant::constantChecks):
> +        * dfg/DFGAbstractInterpreterInlines.h:
> +        (JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
> +        * dfg/DFGByteCodeParser.cpp:
> +        (JSC::DFG::ByteCodeParser::parseBlock):
> +        * dfg/DFGConstantFoldingPhase.cpp:
> +        (JSC::DFG::ConstantFoldingPhase::foldConstants):
> +        (JSC::DFG::ConstantFoldingPhase::emitPutByOffset):
> +        (JSC::DFG::ConstantFoldingPhase::addChecks):
> +        * dfg/DFGNode.h:
> +        (JSC::DFG::Node::convertToMultiGetByOffset):
> +        (JSC::DFG::Node::convertToMultiPutByOffset):
> +        * dfg/DFGStructureAbstractValue.h:
> +        (JSC::DFG::StructureAbstractValue::set):
> +
> [phone]  Filip Pizlo  <[e-mail]>
> +

I've reverted this locally.

[Oliver Hunt]

(Sorry that took so long I just wanted to checkout the branch and try to get a more complete understanding of what's going on.  Kind of lost track over the last week)

[Filip Pizlo]

Landed in http://trac.webkit.org/changeset/170275