Bug 134086

Summary:

Add an undo group for each dictated utterance in WebKit

Product:

WebKit

Reporter:

chris fleizach <cfleizach>

Component:

Text

Assignee:

chris fleizach <cfleizach>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, commit-queue, rniwa, sam

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	none
patch	none
patch	none
patch	none
patch	none
patch	enrica: review+, buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2	none

chris fleizach

Reported 2014-06-19 17:56:06 PDT

While dictating on the web, streams of text are entered at different times. To support a sane undo policy, where undo will remove just the last stream of text, instead of all the streamed text, we need to honor the "undoable" attributed text key that tells us when to break undo grouping. <rdar://problem/16601491>

Attachments
patch (30.17 KB, patch) 2014-06-24 23:00 PDT, chris fleizach	no flags	Details Formatted Diff Diff
patch (33.50 KB, patch) 2014-06-24 23:03 PDT, chris fleizach	no flags	Details Formatted Diff Diff
patch (41.38 KB, patch) 2014-06-25 00:30 PDT, chris fleizach	no flags	Details Formatted Diff Diff
patch (41.32 KB, patch) 2014-06-25 08:55 PDT, chris fleizach	no flags	Details Formatted Diff Diff
patch (41.31 KB, patch) 2014-06-25 08:59 PDT, chris fleizach	no flags	Details Formatted Diff Diff
patch (41.35 KB, patch) 2014-06-25 09:05 PDT, chris fleizach	enrica: review+ buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2 (1.29 MB, application/zip) 2014-06-25 09:49 PDT, Build Bot	no flags	Details
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

chris fleizach

Comment 1 2014-06-24 23:00:07 PDT

Created attachment 233789 [details] patch

WebKit Commit Bot

Comment 2 2014-06-24 23:01:26 PDT

Attachment 233789 [details] did not pass style-queue: ERROR: Source/WebKit/mac/WebView/WebHTMLView.mm:6046: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit2/UIProcess/API/mac/WKView.mm:2242: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 2 in 21 files If any of these errors are false positives, please file a bug against check-webkit-style.

chris fleizach

Comment 3 2014-06-24 23:03:18 PDT

Created attachment 233790 [details] patch

WebKit Commit Bot

Comment 4 2014-06-24 23:04:10 PDT

Attachment 233790 [details] did not pass style-queue: ERROR: Source/WebKit/mac/WebView/WebHTMLView.mm:6046: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit2/UIProcess/API/mac/WKView.mm:2242: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 2 in 23 files If any of these errors are false positives, please file a bug against check-webkit-style.

chris fleizach

Comment 5 2014-06-25 00:30:48 PDT

Created attachment 233794 [details] patch

WebKit Commit Bot

Comment 6 2014-06-25 00:32:11 PDT

Attachment 233794 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/mac/PageClientImpl.mm:363: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/mac/WebView/WebHTMLView.mm:6046: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit2/UIProcess/API/mac/WKView.mm:2242: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/editing/mac/TextUndoInsertionMarkupMac.h:44: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 4 in 24 files If any of these errors are false positives, please file a bug against check-webkit-style.

chris fleizach

Comment 7 2014-06-25 08:55:53 PDT

Created attachment 233816 [details] patch

WebKit Commit Bot

Comment 8 2014-06-25 08:58:29 PDT

Attachment 233816 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/mac/PageClientImpl.mm:363: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/mac/WebView/WebHTMLView.mm:6046: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit2/UIProcess/API/mac/WKView.mm:2242: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/editing/mac/TextUndoInsertionMarkupMac.h:44: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 4 in 24 files If any of these errors are false positives, please file a bug against check-webkit-style.

chris fleizach

Comment 9 2014-06-25 08:59:32 PDT

Created attachment 233817 [details] patch

WebKit Commit Bot

Comment 10 2014-06-25 09:02:08 PDT

Attachment 233817 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/mac/PageClientImpl.mm:363: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/mac/WebView/WebHTMLView.mm:6046: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit2/UIProcess/API/mac/WKView.mm:2242: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 3 in 24 files If any of these errors are false positives, please file a bug against check-webkit-style.

chris fleizach

Comment 11 2014-06-25 09:05:48 PDT

Created attachment 233818 [details] patch

WebKit Commit Bot

Comment 12 2014-06-25 09:07:08 PDT

Attachment 233818 [details] did not pass style-queue: ERROR: Source/WebKit/mac/WebView/WebHTMLView.mm:6046: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit2/UIProcess/API/mac/WKView.mm:2242: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 2 in 24 files If any of these errors are false positives, please file a bug against check-webkit-style.

Enrica Casucci

Comment 13 2014-06-25 09:14:18 PDT

Comment on attachment 233818 [details] patch Looks good to me. Please make sure the EWS are all green before landing.

Build Bot

Comment 14 2014-06-25 09:49:52 PDT

Comment on attachment 233818 [details] patch Attachment 233818 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6348078684569600 New failing tests: media/W3C/video/src/src_reflects_attribute_not_source_elements.html

Build Bot

Comment 15 2014-06-25 09:49:54 PDT

Created attachment 233821 [details] Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-12 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5

chris fleizach

Comment 16 2014-06-25 16:51:34 PDT

http://trac.webkit.org/changeset/170447

Sam Weinig

Comment 17 2014-06-25 21:49:54 PDT

Comment on attachment 233818 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=233818&action=review > Source/WebCore/editing/mac/TextUndoInsertionMarkup.h:31 > +#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 10100 > +#define WTF_USE_INSERTION_UNDO_GROUPING 1 > +#endif // __MAC_OS_X_VERSION_MIN_REQUIRED >= 10100 This should be in Platform.h

chris fleizach

Comment 18 2014-06-26 10:02:00 PDT

(In reply to comment #17) > (From update of attachment 233818 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=233818&action=review > > > Source/WebCore/editing/mac/TextUndoInsertionMarkup.h:31 > > +#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 10100 > > +#define WTF_USE_INSERTION_UNDO_GROUPING 1 > > +#endif // __MAC_OS_X_VERSION_MIN_REQUIRED >= 10100 > > This should be in Platform.h Done. Thanks http://trac.webkit.org/changeset/170482

Sam Weinig

Comment 19 2014-06-26 10:06:06 PDT

(In reply to comment #18) > (In reply to comment #17) > > (From update of attachment 233818 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=233818&action=review > > > > > Source/WebCore/editing/mac/TextUndoInsertionMarkup.h:31 > > > +#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 10100 > > > +#define WTF_USE_INSERTION_UNDO_GROUPING 1 > > > +#endif // __MAC_OS_X_VERSION_MIN_REQUIRED >= 10100 > > > > This should be in Platform.h > > Done. Thanks > > http://trac.webkit.org/changeset/170482 Thank you!

Note You need to log in before you can comment on or make changes to this bug.