Bug 134066

Summary:

[EFL] Add gstreamer as dependecy of EFL after r169785

Product:

WebKit

Reporter:

Éva Balázsfalvi <evab.u-szeged>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, evab.u-szeged, gyuyoung.kim, ossy

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Éva Balázsfalvi 2014-06-19 11:11:46 PDT

Tools/Scripts/update-webkitefl-libs fails after r169785 with the following error:


configure: error: Package requirements (gstreamer-1.0) were not met:
No package 'gstreamer-1.0' found
Consider adjusting the PKG_CONFIG_PATH environment variable if you
installed software in a non-standard prefix.
Alternatively, you may set the environment variables GSTREAMER_CFLAGS
and GSTREAMER_LIBS to avoid the need to call pkg-config.
See the pkg-config man page for more details.


We should add gstreamer and gst-plugins-base to EFL's dependency list.

Comment 1 Éva Balázsfalvi 2014-06-19 11:14:03 PDT

Created attachment 233369 [details]
Patch

Comment 2 Gyuyoung Kim 2014-06-19 23:15:05 PDT

Comment on attachment 233369 [details]
Patch

LGTM

Comment 3 Csaba Osztrogonác 2014-06-20 00:13:20 PDT

Comment on attachment 233369 [details]
Patch

Nice catch, it was really annoying bug. ;)

Comment 4 Csaba Osztrogonác 2014-06-20 00:56:09 PDT

Comment on attachment 233369 [details]
Patch

Clearing flags on attachment: 233369

Committed r170181: <http://trac.webkit.org/changeset/170181>

Comment 5 Csaba Osztrogonác 2014-06-20 00:56:16 PDT

All reviewed patches have been landed.  Closing bug.