Bug 134061

Summary:

check-webkit-style does not understand Obj-C literal syntax for NSDictionary

Product:

WebKit

Reporter:

David Kilzer (:ddkilzer) <ddkilzer>

Component:

Tools / Tests

Assignee:

David Kilzer (:ddkilzer) <ddkilzer>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, darin, dbates, glenn, joepeck, mitz, ossy, thorton

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch v1	none

Description David Kilzer (:ddkilzer) 2014-06-19 08:48:14 PDT

See Bug 134052 Comment #2 <https://bugs.webkit.org/show_bug.cgi?id=134052#c2>:

Attachment 233344 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:694:  Missing space before {  [whitespace/braces] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 1 David Kilzer (:ddkilzer) 2014-06-19 09:24:04 PDT

Created attachment 233363 [details]
Patch v1

Comment 2 WebKit Commit Bot 2014-06-19 10:48:53 PDT

Comment on attachment 233363 [details]
Patch v1

Clearing flags on attachment: 233363

Committed r170152: <http://trac.webkit.org/changeset/170152>

Comment 3 WebKit Commit Bot 2014-06-19 10:48:56 PDT

All reviewed patches have been landed.  Closing bug.