Bug 134061

Summary: check-webkit-style does not understand Obj-C literal syntax for NSDictionary
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: Tools / TestsAssignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, dbates, glenn, joepeck, mitz, ossy, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch v1 none

David Kilzer (:ddkilzer)
Reported 2014-06-19 08:48:14 PDT
See Bug 134052 Comment #2 <https://bugs.webkit.org/show_bug.cgi?id=134052#c2>: Attachment 233344 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:694: Missing space before { [whitespace/braces] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Attachments
Patch v1 (2.77 KB, patch)
2014-06-19 09:24 PDT, David Kilzer (:ddkilzer) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1 2014-06-19 09:24:04 PDT
Created attachment 233363 [details] Patch v1
WebKit Commit Bot
Comment 2 2014-06-19 10:48:53 PDT
Comment on attachment 233363 [details] Patch v1 Clearing flags on attachment: 233363 Committed r170152: <http://trac.webkit.org/changeset/170152>
WebKit Commit Bot
Comment 3 2014-06-19 10:48:56 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.