Bug 13403

Summary: REGRESSION (r18875-r18899): Can no longer type into search form field after searching and then clicking "back"
Product: WebKit Reporter: David Glover <wk>
Component: FormsAssignee: mitz <mitz>
Status: RESOLVED FIXED    
Severity: Major CC: adele, mitz, mrowe
Priority: P1 Keywords: NeedsRadar, NeedsReduction, Regression
Version: 523.x (Safari 3)   
Hardware: Macintosh   
OS: Mac OS X 10.4   
URL: http://www.apple.com/downloads/macosx/
Attachments:
Description Flags
Patch darin: review+

Description David Glover 2007-04-19 07:13:53 PDT
1. Go to http://www.apple.com/downloads/macosx/
2. Type something into the search box in the top left and press Return. (I searched for "rss".)
3. Click the Back button.
4. Try to edit the contents of the search box.

Result: You can delete characters, but you can't type new characters.

This is not reproduced in 419.3.
Comment 1 Brady Eidson 2007-04-19 10:18:34 PDT
David,

"419.x" is the release version of Safari, and "522+" is all recent WebKit nightlies.  

Could you give us more information such as which WebKit nightly you were using when you saw that it was broken?  
Also it is often valuable to download some of the older WebKit nightlies to discover when this broke.

Thanks!
Comment 2 David Glover 2007-04-19 10:24:35 PDT
I was using today's (April 19 2007) nightly.
Comment 3 Darin Adler 2007-04-19 10:25:45 PDT
This is specific to this particular page, and doesn't happen on other pages.

I'm pretty sure it's due to some JavaScript on the page that's trapping the key down events.
Comment 4 mitz@webkit.org 2007-04-19 10:29:34 PDT
(In reply to comment #3)
> This is specific to this particular page, and doesn't happen on other pages.
> 
> I'm pretty sure it's due to some JavaScript on the page that's trapping the key
> down events.
> 

I'm seeing some painting artifacts when I type in the field after back navigation, so I think it's more than that.
Comment 5 mitz@webkit.org 2007-04-19 10:37:11 PDT
Regressed between r18875 and r18899. My suspect is <http://trac.webkit.org/projects/webkit/changeset/18877>.
Comment 6 mitz@webkit.org 2007-04-19 12:40:55 PDT
Created attachment 14093 [details]
Patch

I don't know how to make a layout test for this bug.
Comment 7 Darin Adler 2007-04-19 18:50:22 PDT
Comment on attachment 14093 [details]
Patch

r=me
Comment 8 Mark Rowe (bdash) 2007-04-19 19:28:48 PDT
Landed in r20964.