Bug 134028

Summary: [GTK] XPathNSResolver should be exposed as an interface instead of as a class
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: BindingsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bunhere, cdumez, commit-queue, glenn, gustavo, gyuyoung.kim, rakuco, sergio
Priority: P2 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 133724, 134297    
Attachments:
Description Flags
Patch
none
Updated to build on current git master gustavo: review+

Description Carlos Garcia Campos 2014-06-18 06:25:19 PDT
Similar to the NodeFilter case (see bug #93002), but in this case the XPathNSResolver interface can be implemented internally or by the application. So we need to expose it as an interface, but we also need to wrap NativeXPathNSResolver internally to provide a default implementation for methods that create a XPathNSResolver.
Comment 1 Carlos Garcia Campos 2014-06-24 05:54:41 PDT
Created attachment 233696 [details]
Patch
Comment 2 Carlos Garcia Campos 2014-06-25 04:52:20 PDT
Created attachment 233804 [details]
Updated to build on current git master
Comment 3 Gustavo Noronha (kov) 2014-07-01 09:03:33 PDT
Comment on attachment 233804 [details]
Updated to build on current git master

LGTM
Comment 4 Carlos Garcia Campos 2014-07-02 00:04:58 PDT
Committed r170700: <http://trac.webkit.org/changeset/170700>