| Summary: | Web Inspector: JS PrettyPrinting unary - and + issues | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||||||||
| Component: | Web Inspector | Assignee: | Nobody <webkit-unassigned> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | commit-queue, graouts, joepeck, jonowells, timothy, webkit-bug-importer | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | 412.x | ||||||||||||
| Hardware: | All | ||||||||||||
| OS: | All | ||||||||||||
| Attachments: |
|
||||||||||||
In fact, this produces even worse results:
f(-1);
x=-1+1;
f(+1);
x=+1+1;
Namely that "=-" and "=+" are treated as operators. That is CodeMirror's tokenization, maybe that should be improved.
*** Bug 153830 has been marked as a duplicate of this bug. *** Created attachment 270606 [details]
[PATCH] Proposed Fix
This also fixed an issue with '%' (modulo) operator and ternary in array / property index '[' ']' scopes. Created attachment 270608 [details]
[PATCH] For Landing
Comment on attachment 270608 [details] [PATCH] For Landing Clearing flags on attachment: 270608 Committed r196098: <http://trac.webkit.org/changeset/196098> Comment on attachment 270606 [details] [PATCH] Proposed Fix Attachment 270606 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/779118 New failing tests: imported/w3c/web-platform-tests/streams-api/readable-streams/garbage-collection-2.html Created attachment 270613 [details]
Archive of layout-test-results from ews117 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 270608 [details] [PATCH] For Landing Attachment 270608 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/779144 New failing tests: imported/w3c/web-platform-tests/streams-api/readable-streams/garbage-collection-2.html Created attachment 270615 [details]
Archive of layout-test-results from ews114 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114 Port: mac-yosemite Platform: Mac OS X 10.10.5
|
TEST: f(-1); x = -1 + 1; f(+1); x = +1 + 1; OUTPUT: f( - 1); x = - 1 + 1; f( + 1); x = + 1 + 1; EXPECTED: f(-1); x = -1 + 1; f(+1); x = +1 + 1;