Bug 134001

Summary: Web Inspector: PrettyPrinting regression on "var a=1"
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, graouts, joepeck, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix none

Joseph Pecoraro
Reported 2014-06-17 16:05:30 PDT
“var a=1;” prettyprints to “var a= 1;” but should pretty print to “var a = 1;”
Attachments
[PATCH] Proposed Fix (3.36 KB, patch)
2014-06-17 16:26 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2014-06-17 16:07:48 PDT
<rdar://problem/17350819>
Joseph Pecoraro
Comment 2 2014-06-17 16:08:31 PDT
Seems like shouldHaveSpaceBeforeToken is checking for operators, but assumes operators don't have a token, but maybe they do now, with the token name "operator".
Joseph Pecoraro
Comment 3 2014-06-17 16:26:30 PDT
Created attachment 233268 [details] [PATCH] Proposed Fix Makes JavaScript Pretty Printing tests pass in my checkout.
WebKit Commit Bot
Comment 4 2014-06-17 17:29:20 PDT
Comment on attachment 233268 [details] [PATCH] Proposed Fix Clearing flags on attachment: 233268 Committed r170088: <http://trac.webkit.org/changeset/170088>
WebKit Commit Bot
Comment 5 2014-06-17 17:29:22 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.