| Summary: | Remove unnecessary Structure flags from generated bindings | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||
| Component: | New Bugs | Assignee: | Sam Weinig <sam> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | alecflett, cdumez, cgarcia, commit-queue, dbates, eric.carlson, glenn, jer.noble, jsbell, oliver, philipj, sergio | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Sam Weinig
2014-06-17 12:42:00 PDT
Created attachment 233252 [details]
Patch
Comment on attachment 233252 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=233252&action=review This patch looks sane to me. > Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:4350 > + push(@$outputArray, "protected:\n"); Nit: This line should be indented such that the 'p' in "push" left aligned with the 'p' in "push" on the line below. |