Bug 133988

Summary:

Use strongly typed enums for AnimationState and AnimationInputState

Product:

WebKit

Reporter:

Anders Carlsson <andersca>

Component:

New Bugs

Assignee:

Anders Carlsson <andersca>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, dino, dstockwell, simon.fraser

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	thorton: review+, thorton: commit-queue-

Description Anders Carlsson 2014-06-17 11:37:47 PDT

Use strongly typed enums for AnimationState and AnimationInputState

Comment 1 Anders Carlsson 2014-06-17 12:33:11 PDT

Created attachment 233249 [details]
Patch

Comment 2 WebKit Commit Bot 2014-06-17 12:34:43 PDT

Attachment 233249 [details] did not pass style-queue:


ERROR: Source/WebCore/page/animation/AnimationBase.cpp:200:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
ERROR: Source/WebCore/page/animation/AnimationBase.h:72:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/page/animation/AnimationBase.h:73:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/page/animation/AnimationBase.h:74:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/page/animation/AnimationBase.h:75:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/page/animation/AnimationBase.h:76:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/page/animation/AnimationBase.h:77:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/page/animation/AnimationBase.h:78:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/page/animation/AnimationBase.h:79:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/page/animation/AnimationBase.h:80:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/page/animation/AnimationBase.h:81:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/page/animation/AnimationBase.h:82:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/page/animation/AnimationBase.h:83:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/page/animation/AnimationBase.h:84:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/page/animation/AnimationBase.h:88:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/page/animation/AnimationBase.h:89:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/page/animation/AnimationBase.h:90:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/page/animation/AnimationBase.h:91:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/page/animation/AnimationBase.h:92:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/page/animation/AnimationBase.h:93:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/page/animation/AnimationBase.h:94:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/page/animation/AnimationBase.h:95:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/page/animation/AnimationBase.h:96:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/page/animation/AnimationBase.h:97:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/page/animation/AnimationBase.h:98:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/page/animation/AnimationBase.h:99:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/page/animation/AnimationBase.h:100:  One space before end of line comments  [whitespace/comments] [5]
Total errors found: 27 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Tim Horton 2014-06-17 12:48:45 PDT

Comment on attachment 233249 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=233249&action=review

> Source/WebCore/page/animation/AnimationBase.h:87
> +    enum AnimationStateInput {

where's the "class"?

Comment 4 Anders Carlsson 2014-06-17 13:19:41 PDT

Committed r170070: <http://trac.webkit.org/changeset/170070>