Bug 13398

Summary: [GDK] Bring the port up to date
Product: WebKit Reporter: Alp Toker <alp>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 523.x (Safari 3)   
Hardware: All   
OS: Linux   
Attachments:
Description Flags
gdk port build fixes
sam: review+
gdk port build fixes (take two, with whitespace fixes) mrowe: review+

Alp Toker
Reported 2007-04-18 13:19:32 PDT
Patch attached for review.
Attachments
gdk port build fixes (3.52 KB, patch)
2007-04-18 13:21 PDT, Alp Toker 		sam: review+
DetailsFormatted DiffDiff
gdk port build fixes (take two, with whitespace fixes) (3.52 KB, patch)
2007-04-18 16:52 PDT, Alp Toker 		mrowe: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alp Toker
Comment 1 2007-04-18 13:21:25 PDT
Created attachment 14080 [details] gdk port build fixes
Sam Weinig
Comment 2 2007-04-18 14:05:07 PDT
Comment on attachment 14080 [details] gdk port build fixes This seems fine except for 2 nit picks. First, there are a couple tabs in the ChangeLog that should be removed before landing. Second, there should be a space after the "return 0;" here: +WebCore::Page* ChromeClientGdk::createModalDialog(Frame*, const FrameLoadRequest&) { notImplementedGdk(); return 0;} Otherwise, r=me.
Alp Toker
Comment 3 2007-04-18 16:52:07 PDT
Created attachment 14082 [details] gdk port build fixes (take two, with whitespace fixes)
Mark Rowe (bdash)
Comment 4 2007-04-18 18:07:40 PDT
Landed in r20939.
Note You need to log in before you can comment on or make changes to this bug.