| Summary: | [ftlopt] Fold constant Phis | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Filip Pizlo <fpizlo> | ||||||
| Component: | JavaScriptCore | Assignee: | Filip Pizlo <fpizlo> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | barraclough, ggaren, mark.lam, mhahnenberg, msaboff, oliver, sam | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Attachments: |
|
||||||||
|
Description
Filip Pizlo
2014-06-16 20:55:33 PDT
Created attachment 233213 [details]
the patch
Comment on attachment 233213 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=233213&action=review r=me > Source/JavaScriptCore/dfg/DFGInPlaceAbstractState.h:136 > + // This method is evil - it causes a huge maintenance headache and there is a gross amount of > + // code devoted to it. It would be much nicer to just always run the constant folder on each > + // block. But, the last time we did it, it was a 1% SunSpider regression: > + // https://bugs.webkit.org/show_bug.cgi?id=133947 > + // So, we should probably keep this method. I might be willing to eat 1% for this -- particularly if the overall effect on JetStream is less than 1%. Created attachment 233245 [details]
better patch
Comment on attachment 233245 [details]
better patch
r=me
Landed in http://trac.webkit.org/changeset/170064 |