Bug 133967

Summary: [ftlopt] Fold constant Phis
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, ggaren, mark.lam, mhahnenberg, msaboff, oliver, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
the patch
ggaren: review+
better patch mhahnenberg: review+

Filip Pizlo
Reported 2014-06-16 20:55:33 PDT
Patch forthcoming.
Attachments
the patch (9.30 KB, patch)
2014-06-16 21:01 PDT, Filip Pizlo 		ggaren: review+
DetailsFormatted DiffDiff
better patch (10.68 KB, patch)
2014-06-17 11:42 PDT, Filip Pizlo 		mhahnenberg: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2014-06-16 21:01:34 PDT
Created attachment 233213 [details] the patch
Geoffrey Garen
Comment 2 2014-06-17 11:13:03 PDT
Comment on attachment 233213 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=233213&action=review r=me > Source/JavaScriptCore/dfg/DFGInPlaceAbstractState.h:136 > + // This method is evil - it causes a huge maintenance headache and there is a gross amount of > + // code devoted to it. It would be much nicer to just always run the constant folder on each > + // block. But, the last time we did it, it was a 1% SunSpider regression: > + // https://bugs.webkit.org/show_bug.cgi?id=133947 > + // So, we should probably keep this method. I might be willing to eat 1% for this -- particularly if the overall effect on JetStream is less than 1%.
Filip Pizlo
Comment 3 2014-06-17 11:42:19 PDT
Created attachment 233245 [details] better patch
Mark Hahnenberg
Comment 4 2014-06-17 11:44:28 PDT
Comment on attachment 233245 [details] better patch r=me
Filip Pizlo
Comment 5 2014-06-17 12:02:40 PDT
Landed in http://trac.webkit.org/changeset/170064
Note You need to log in before you can comment on or make changes to this bug.