Bug 133951

Summary: Web Inspector: Two lines in CSS rule are hidden until resize or click
Product: WebKit Reporter: Timothy Hatcher <timothy>
Component: Web InspectorAssignee: Jonathan Wells <jonowells>
Status: RESOLVED FIXED    
Severity: Normal CC: graouts, joepeck, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Test Case
none
Bug
none
After Resize
none
[PATCH] Attempted fix, update to CodeMirror 4.2.0 joepeck: review+

Timothy Hatcher
Reported 2014-06-16 14:19:31 PDT
Created attachment 233177 [details] Test Case The color and background-color on the attached page's icon don't show up in the rule sidebar until some refresh happens.
Attachments
Test Case (880 bytes, text/html)
2014-06-16 14:19 PDT, Timothy Hatcher 		no flags
Details
Bug (69.09 KB, image/png)
2014-06-16 14:21 PDT, Timothy Hatcher 		no flags
Details
After Resize (88.75 KB, image/png)
2014-06-16 14:22 PDT, Timothy Hatcher 		no flags
Details
[PATCH] Attempted fix, update to CodeMirror 4.2.0 (51.43 KB, patch)
2014-06-16 20:55 PDT, Jonathan Wells 		joepeck: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2014-06-16 14:21:02 PDT
<rdar://problem/17332268>
Timothy Hatcher
Comment 2 2014-06-16 14:21:47 PDT
Created attachment 233178 [details] Bug
Timothy Hatcher
Comment 3 2014-06-16 14:22:02 PDT
Created attachment 233179 [details] After Resize
Jonathan Wells
Comment 4 2014-06-16 20:44:23 PDT
This is a bug in CodeMirror 4.1. This is fixed in CodeMirror 4.2. I will update.
Jonathan Wells
Comment 5 2014-06-16 20:55:55 PDT
Created attachment 233212 [details] [PATCH] Attempted fix, update to CodeMirror 4.2.0
Joseph Pecoraro
Comment 6 2014-06-17 11:16:15 PDT
Comment on attachment 233212 [details] [PATCH] Attempted fix, update to CodeMirror 4.2.0 Looks good to me. Do PrettyPrinting tests continue to pass?
Jonathan Wells
Comment 7 2014-06-17 15:16:02 PDT
The second one fails: /* PASS: js-tests/block-comment.js */ /* FAIL: js-tests/single-statement-blocks.js */ /* PASS: js-tests/switch-case-default.js */ However I think this has been the case maybe since the original CodeMirror update. This can be fixed in another bug. This might need a rebaseline.
Jonathan Wells
Comment 8 2014-06-17 15:38:30 PDT
Landed in r170080.
Jonathan Wells
Comment 9 2014-06-17 15:40:23 PDT
<http://trac.webkit.org/changeset/170080>
Note You need to log in before you can comment on or make changes to this bug.