Bug 133942

Summary: [UI-side compositing] fix reflections on composited layers
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, glenn, gyuyoung.kim, jer.noble, kondapallykalyan, philipj, sergio, simon.fraser, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP patch
none
Patch
none
Patch thorton: review+

Simon Fraser (smfr)
Reported 2014-06-16 08:39:38 PDT
[UI-side compositing] fix reflections on composited layers
Attachments
WIP patch (28.39 KB, patch)
2014-06-16 08:40 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Patch (33.74 KB, patch)
2014-06-16 22:02 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Patch (35.65 KB, patch)
2014-06-17 10:06 PDT, Simon Fraser (smfr) 		thorton: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2014-06-16 08:40:11 PDT
Created attachment 233161 [details] WIP patch
Simon Fraser (smfr)
Comment 2 2014-06-16 22:02:34 PDT
Created attachment 233217 [details] Patch
Gyuyoung Kim
Comment 3 2014-06-17 03:06:49 PDT
FYI, efl-wk2 ews is false alarm. I succeed to build WebKit EFL2 with this patch locally.
Simon Fraser (smfr)
Comment 4 2014-06-17 10:06:49 PDT
Created attachment 233236 [details] Patch
Tim Horton
Comment 5 2014-06-17 11:47:55 PDT
Comment on attachment 233236 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=233236&action=review > Source/WebCore/ChangeLog:12 > + This layer may be told that its content need updating out of order during contents > Source/WebCore/ChangeLog:16 > + In the UI process, a new step is added to emoteLayerTreeHost::updateLayerTree() *Re*mote > Source/WebCore/platform/graphics/ca/mac/PlatformCALayerMac.mm:330 > + CALayer* caLayer = layer->m_layer.get(); star on the wrong side. isn't there a platformLayer getter, too? > Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:201 > + m_context->layerPropertyChangedInTransactionBuilding(this); WhileBuildingTransaction?
Simon Fraser (smfr)
Comment 6 2014-06-17 14:07:26 PDT
https://trac.webkit.org/r170071
Note You need to log in before you can comment on or make changes to this bug.