Bug 133922

Summary: Replace StringImpl* callback parameters with const String&
Product: WebKit Reporter: mitz
Component: WebKit2Assignee: mitz
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Use const String& in callbacks sam: review+

mitz
Reported 2014-06-14 18:25:14 PDT
Some callbacks have StringImpl* parameters.
Attachments
Use const String& in callbacks (9.18 KB, patch)
2014-06-14 18:28 PDT, mitz 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
mitz
Comment 1 2014-06-14 18:28:02 PDT
Created attachment 233132 [details] Use const String& in callbacks
WebKit Commit Bot
Comment 2 2014-06-14 18:29:17 PDT
Attachment 233132 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/API/C/WKPage.cpp:1584: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebKit2/UIProcess/API/C/WKPage.cpp:1584: Extra space before [ [whitespace/braces] [5] Total errors found: 2 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
mitz
Comment 3 2014-06-14 19:11:15 PDT
Committed <http://trac.webkit.org/r169987>.
Note You need to log in before you can comment on or make changes to this bug.