Bug 133921

Summary: invalidateCallbackMap doesn’t pass the error parameter on to invalidate(), so script completion handler is passed the wrong error
Product: WebKit Reporter: mitz
Component: WebKit2Assignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, commit-queue, eric.carlson, glenn, jer.noble, philipj, sergio
Priority: P1 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mitz: review+

mitz
Reported 2014-06-14 16:06:29 PDT
invalidateCallbackMap in GenericCallback.h doesn’t pass its error parameter on to the callbacks’ invalidate function. Therefore the error passed into -[WKWebView evaluateJavaScript:completionHandler:]’s completion handler is always WKErrorUnknown, and the completion handler is called synchronously in the PageInvalidated case, even though it’s supposed to be deferred.
Attachments
Patch (16.05 KB, patch)
2014-06-15 10:24 PDT, Anders Carlsson 		mitz: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
mitz
Comment 1 2014-06-14 16:08:25 PDT
<rdar://problem/17316653>
Anders Carlsson
Comment 2 2014-06-15 10:24:07 PDT
Created attachment 233141 [details] Patch
Anders Carlsson
Comment 3 2014-06-15 11:07:36 PDT
Committed r169990: <http://trac.webkit.org/changeset/169990>
Note You need to log in before you can comment on or make changes to this bug.