Bug 133914
| Summary: | IDL Constructor does not allow too many arguments | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Dirk Schulze <krit> |
| Component: | Bindings | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | dbates |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Dirk Schulze
[
Conditional=GEOMETRY,
Constructor,
Constructor(Dictionary point),
Constructor(unrestricted double x, unrestricted double y),
Constructor(unrestricted double x, unrestricted double y, unrestricted double z),
Constructor(unrestricted double x, unrestricted double y, unrestricted double z, unrestricted double w)
] interface DOMPoint : DOMPointReadOnly {
Code generator makes every check equal check. Last check should be >=:
size_t argsCount = exec->argumentCount();
if (argsCount == 0)
return JSDOMPointConstructor::constructJSDOMPoint1(exec);
if (argsCount == 1)
return JSDOMPointConstructor::constructJSDOMPoint2(exec);
if (argsCount == 2)
return JSDOMPointConstructor::constructJSDOMPoint3(exec);
if (argsCount == 3)
return JSDOMPointConstructor::constructJSDOMPoint4(exec);
if (argsCount == 4)
return JSDOMPointConstructor::constructJSDOMPoint5(exec);
return throwVMTypeError(exec);
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Daniel Bates
This bug is fixed with the patch for bug #136134. That is, we emit code to ignore extra arguments per <http://www.w3.org/TR/2012/CR-WebIDL-20120419/#es-interface-call>.
Daniel Bates
(In reply to comment #1)
> This bug is fixed with the patch for bug #136134. That is, we emit code to
> ignore extra arguments per
> <http://www.w3.org/TR/2012/CR-WebIDL-20120419/#es-interface-call>.
err, I meant bug #146515.