Bug 133913

Summary:

CSS JIT: add support for the :lang() pseudo class

Product:

WebKit

Reporter:

Benjamin Poulain <benjamin>

Component:

New Bugs

Assignee:

Benjamin Poulain <benjamin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

allan.jensen, cmarcelo, commit-queue, esprehn+autocc, glenn, gyuyoung.kim, kangil.han, kling, macpherson, menard

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	kling: review+

Description Benjamin Poulain 2014-06-14 14:02:00 PDT

CSS JIT: add support for the :lang() pseudo class

Comment 1 Benjamin Poulain 2014-06-14 14:04:06 PDT

Created attachment 233120 [details]
Patch

Comment 2 Alexey Proskuryakov 2014-06-14 14:44:12 PDT

See also bug 16801.

Comment 3 Andreas Kling 2014-06-15 00:28:13 PDT

Comment on attachment 233120 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=233120&action=review

r=me

> Source/WebCore/css/SelectorCheckerTestFunctions.h:118
> +    if (value.startsWith(String(*filter), false)) {

String(*filter) will ref() and unref() the StringImpl here, you can do better. :)

Comment 4 Benjamin Poulain 2014-06-15 23:54:49 PDT

Committed r170001: <http://trac.webkit.org/changeset/170001>