Bug 133909

Summary: Get rid of GenericAPICallback
Product: WebKit Reporter: mitz
Component: WebKit2Assignee: mitz
Status: RESOLVED FIXED    
Severity: Normal CC: berto, cgarcia, commit-queue, eric.carlson, glenn, gustavo, jer.noble, mrobinson, philipj, sam, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Replace GenericAPICallback with genericCallbackFunction()
sam: review+, mitz: commit-queue-
Patch none

mitz
Reported 2014-06-14 12:57:50 PDT
In preparation for passing callbacks as functions, replace GenericAPICallback::create, which returned a GenericCallback, with a function template that returns an appropriate callback function.
Attachments
Replace GenericAPICallback with genericCallbackFunction() (21.00 KB, patch)
2014-06-14 13:03 PDT, mitz 		sam: review+
mitz: commit-queue-
DetailsFormatted DiffDiff
Patch (22.69 KB, patch)
2014-06-14 14:36 PDT, mitz 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
mitz
Comment 1 2014-06-14 13:03:59 PDT
Created attachment 233116 [details] Replace GenericAPICallback with genericCallbackFunction()
WebKit Commit Bot
Comment 2 2014-06-14 13:05:57 PDT
Attachment 233116 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/GenericCallback.h:174: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebKit2/UIProcess/GenericCallback.h:174: Extra space before [ [whitespace/braces] [5] Total errors found: 2 in 13 files If any of these errors are false positives, please file a bug against check-webkit-style.
mitz
Comment 3 2014-06-14 14:36:07 PDT
Created attachment 233123 [details] Patch
WebKit Commit Bot
Comment 4 2014-06-14 14:36:54 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
WebKit Commit Bot
Comment 5 2014-06-14 14:37:04 PDT
Attachment 233123 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/GenericCallback.h:174: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebKit2/UIProcess/GenericCallback.h:174: Extra space before [ [whitespace/braces] [5] Total errors found: 2 in 14 files If any of these errors are false positives, please file a bug against check-webkit-style.
mitz
Comment 6 2014-06-14 16:12:24 PDT
Committed <http://trac.webkit.org/r169984>.
Note You need to log in before you can comment on or make changes to this bug.