Bug 133908

Summary: Some classes with virtual methods are missing virtual destructors
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED INVALID    
Severity: Normal CC: berto, cgarcia, cmarcelo, commit-queue, eric.carlson, glenn, gustavo, hta, jer.noble, kondapallykalyan, luiz, mrobinson, noam, philipj, sergio, simon.fraser, tommyw
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch andersca: review-

Zan Dobersek
Reported 2014-06-14 12:17:54 PDT
Some classes with virtual methods are missing virtual destructors
Attachments
Patch (10.52 KB, patch)
2014-06-14 12:25 PDT, Zan Dobersek 		andersca: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2014-06-14 12:25:40 PDT
Created attachment 233115 [details] Patch
WebKit Commit Bot
Comment 2 2014-06-14 12:26:38 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Anders Carlsson
Comment 3 2014-06-14 17:35:58 PDT
Comment on attachment 233115 [details] Patch I don't think this warning is useful. Nobody deletes a TextureMapperPlatformLayer::Client for example, so this just creates extra vtable entries for no good reason.
Zan Dobersek
Comment 4 2014-07-29 14:41:53 PDT
-Wdelete-non-virtual-dtor only warns about cases where such classes are actually deleted. There are no such warnings occurring with the current code, so there's nothing to do here.
Note You need to log in before you can comment on or make changes to this bug.