| Summary: | Some classes with virtual methods are missing virtual destructors | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Zan Dobersek <zan> | ||||
| Component: | New Bugs | Assignee: | Zan Dobersek <zan> | ||||
| Status: | RESOLVED INVALID | ||||||
| Severity: | Normal | CC: | berto, cgarcia, cmarcelo, commit-queue, eric.carlson, glenn, gustavo, hta, jer.noble, kondapallykalyan, luiz, mrobinson, noam, philipj, sergio, simon.fraser, tommyw | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Zan Dobersek
2014-06-14 12:17:54 PDT
Created attachment 233115 [details]
Patch
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API Comment on attachment 233115 [details]
Patch
I don't think this warning is useful. Nobody deletes a TextureMapperPlatformLayer::Client for example, so this just creates extra vtable entries for no good reason.
-Wdelete-non-virtual-dtor only warns about cases where such classes are actually deleted. There are no such warnings occurring with the current code, so there's nothing to do here. |