Bug 133902

Summary: Use references instead of pointers to RenderBlock in RenderObject::enclosingBox().
Product: WebKit Reporter: Jeongeun Kim <je_julie.kim>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: calvaris, commit-queue, eric.carlson, esprehn+autocc, glenn, gyuyoung.kim, jer.noble, kondapallykalyan, philipj, sergio, simon.fraser, WebkitBugTracker
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
verification on win-ews none

Jeongeun Kim
Reported 2014-06-14 08:46:07 PDT
Use references instead of pointers to RenderBlock for return type of RenderObject::enclosingBox(). Just a straightforward conversion from pointers to references.
Attachments
Patch (15.09 KB, patch)
2014-06-14 08:54 PDT, Jeongeun Kim 		no flags
DetailsFormatted DiffDiff
verification on win-ews (15.09 KB, patch)
2014-06-16 06:10 PDT, Jeongeun Kim 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jeongeun Kim
Comment 1 2014-06-14 08:54:30 PDT
Created attachment 233108 [details] Patch
Jeongeun Kim
Comment 2 2014-06-16 06:10:50 PDT
Created attachment 233156 [details] verification on win-ews
Jeongeun Kim
Comment 3 2014-06-16 08:37:58 PDT
This patch is for removing "// FIXME: This should return a reference; it can always find the root RenderView." in RenderObject::enclosingBox(). Please take a look. Thanks, Jeongeun
WebKit Commit Bot
Comment 4 2014-06-16 12:52:51 PDT
Comment on attachment 233156 [details] verification on win-ews Clearing flags on attachment: 233156 Committed r170024: <http://trac.webkit.org/changeset/170024>
WebKit Commit Bot
Comment 5 2014-06-16 12:52:56 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.