Bug 133902

Summary:

Use references instead of pointers to RenderBlock in RenderObject::enclosingBox().

Product:

WebKit

Reporter:

Jeongeun Kim <je_julie.kim>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

calvaris, commit-queue, eric.carlson, esprehn+autocc, glenn, gyuyoung.kim, jer.noble, kondapallykalyan, philipj, sergio, simon.fraser, WebkitBugTracker

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
verification on win-ews	none

Description Jeongeun Kim 2014-06-14 08:46:07 PDT

Use references instead of pointers to RenderBlock for return type of RenderObject::enclosingBox().
Just a straightforward conversion from pointers to references.

Comment 1 Jeongeun Kim 2014-06-14 08:54:30 PDT

Created attachment 233108 [details]
Patch

Comment 2 Jeongeun Kim 2014-06-16 06:10:50 PDT

Created attachment 233156 [details]
verification on win-ews

Comment 3 Jeongeun Kim 2014-06-16 08:37:58 PDT

This patch is for removing "// FIXME: This should return a reference; it can always find the root RenderView." in RenderObject::enclosingBox().
Please take a look.
Thanks,
Jeongeun

Comment 4 WebKit Commit Bot 2014-06-16 12:52:51 PDT

Comment on attachment 233156 [details]
verification on win-ews

Clearing flags on attachment: 233156

Committed r170024: <http://trac.webkit.org/changeset/170024>

Comment 5 WebKit Commit Bot 2014-06-16 12:52:56 PDT

All reviewed patches have been landed.  Closing bug.