Bug 133892

Summary: Masks disappear when layers become tiled
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, kondapallykalyan, sergio, simon.fraser, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch thorton: review+

Description Simon Fraser (smfr) 2014-06-13 19:39:14 PDT
Masks disappear when layers become tiled
Comment 1 Simon Fraser (smfr) 2014-06-13 19:50:55 PDT
Created attachment 233099 [details]
Patch
Comment 2 Tim Horton 2014-06-13 21:13:58 PDT
Comment on attachment 233099 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=233099&action=review

> Source/WebCore/ChangeLog:9
> +        There were several problems with tiled mask layers.

Nice!

> Source/WebCore/ChangeLog:22
> +            1. setting a bit on a layer to note that it's being used as a maks.

typo "maks"

> LayoutTests/compositing/masks/become-tiled-mask.html:35
> +    if (window.testRunner)

indentation of this script is wacky (some 2-space, some 4)
Comment 3 Simon Fraser (smfr) 2014-06-14 10:41:34 PDT
https://trac.webkit.org/r169972