Bug 133880

Summary: OSR exit should barrier the Executables for all InlineCallFrames, not just those on the stack at the time of exit
Product: WebKit Reporter: Mark Hahnenberg <mhahnenberg>
Component: JavaScriptCoreAssignee: Mark Hahnenberg <mhahnenberg>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cmarcelo, commit-queue, ggaren
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Mark Hahnenberg
Reported 2014-06-13 13:57:47 PDT
We could have exited due to a value received from an inlined block that's no longer on the stack, so we should just barrier all InlineCallFrames.
Attachments
Patch (3.69 KB, patch)
2014-06-13 13:59 PDT, Mark Hahnenberg 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Hahnenberg
Comment 1 2014-06-13 13:59:39 PDT
Created attachment 233073 [details] Patch
WebKit Commit Bot
Comment 2 2014-06-13 15:19:22 PDT
Comment on attachment 233073 [details] Patch Clearing flags on attachment: 233073 Committed r169951: <http://trac.webkit.org/changeset/169951>
WebKit Commit Bot
Comment 3 2014-06-13 15:19:24 PDT
All reviewed patches have been landed. Closing bug.
Geoffrey Garen
Comment 4 2014-06-16 15:44:21 PDT
<rdar://problem/17276579>
Note You need to log in before you can comment on or make changes to this bug.