Bug 133874

Summary:

Add a HTTPHeaderMap::set overload that takes a HTTPHeaderName

Product:

WebKit

Reporter:

Anders Carlsson <andersca>

Component:

New Bugs

Assignee:

Anders Carlsson <andersca>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ossy

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	thorton: review+

Description Anders Carlsson 2014-06-13 12:16:04 PDT

Add a HTTPHeaderMap::set overload that takes a HTTPHeaderName

Comment 1 Anders Carlsson 2014-06-13 12:17:02 PDT

Created attachment 233067 [details]
Patch

Comment 2 Anders Carlsson 2014-06-13 12:35:34 PDT

Committed r169943: <http://trac.webkit.org/changeset/169943>

Comment 3 Csaba Osztrogonác 2014-06-13 15:01:52 PDT

(In reply to comment #2)
> Committed r169943: <http://trac.webkit.org/changeset/169943>

It broke the EFL and GTK build. :(

Comment 4 Csaba Osztrogonác 2014-06-14 02:07:02 PDT

Buildfix landed in https://trac.webkit.org/changeset/169966 .

Otherwise breaking the build and then going home wasn't a fairplay game ...

Comment 5 Csaba Osztrogonác 2014-06-14 02:08:40 PDT

Comment on attachment 233067 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=233067&action=review

> Source/WebCore/platform/network/HTTPHeaderMap.h:74
> +    template<size_t length> void add(const char (&)[length], const String&) = delete;

I think it was an accidental change, because it is the only one implementaion of add,
and the bug title is about only chaning set. So I removed this deletion in the buildfix.