Bug 133851

Summary: LayoutTests for Gamepad API
Product: WebKit Reporter: Michal Debski <m.debski>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: NEW ---    
Severity: Normal CC: buildbot, bunhere, cdumez, commit-queue, esprehn+autocc, glenn, gyuyoung.kim, macpherson, menard, rakuco, rniwa, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 133850    
Bug Blocks: 133847    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2 none

Description Michal Debski 2014-06-13 06:51:24 PDT
This adds backend for gamepad API LayoutTests. It is fake GamepadsProvider which can be controlled with JavaScript to emulate connecting, disconnecting and interacting with device.
Tests for events are also included.
Comment 1 Michal Debski 2014-06-23 03:21:01 PDT
Created attachment 233592 [details]
Patch
Comment 2 Michal Debski 2014-06-24 07:32:01 PDT
Created attachment 233704 [details]
Patch

Rebase
Comment 3 Michal Debski 2014-06-24 09:53:53 PDT
Created attachment 233711 [details]
Patch

Rebase
Comment 4 WebKit Commit Bot 2014-06-24 09:55:56 PDT
Attachment 233711 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/mock/MockGamepadsProvider.h:36:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/platform/mock/MockGamepadsProvider.h:50:  Missing space inside { }.  [whitespace/braces] [5]
ERROR: Source/WebCore/platform/mock/MockGamepadsProvider.h:67:  Missing space inside { }.  [whitespace/braces] [5]
ERROR: Source/WebCore/platform/mock/MockGamepadsProvider.h:77:  The parameter name "manager" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/mock/MockGamepadsProvider.h:77:  The parameter name "internals" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/mock/MockGamepadsProvider.cpp:30:  You should add a blank line after implementation file's own header.  [build/include_order] [4]
ERROR: Source/WebCore/platform/mock/MockGamepadsProvider.cpp:30:  You should not add a blank line before implementation file's own header.  [build/include_order] [4]
ERROR: Source/WebCore/platform/mock/MockGamepadsProvider.cpp:63:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/mock/MockGamepadsProvider.cpp:40:  Missing space before ( in if(  [whitespace/parens] [5]
ERROR: Source/WebCore/platform/mock/MockGamepadsProvider.cpp:62:  Missing space before {  [whitespace/braces] [5]
ERROR: Source/WebCore/platform/mock/MockGamepadsProvider.cpp:63:  Missing space before {  [whitespace/braces] [5]
ERROR: Source/WebCore/testing/Internals.h:42:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/testing/Internals.h:208:  The parameter name "provider" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/testing/Internals.cpp:119:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/testing/Internals.cpp:327:  Missing space before {  [whitespace/braces] [5]
ERROR: Source/WebCore/testing/Internals.cpp:1311:  Missing space before {  [whitespace/braces] [5]
Total errors found: 16 in 17 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Build Bot 2014-06-24 11:56:19 PDT
Comment on attachment 233711 [details]
Patch

Attachment 233711 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5222744664834048

New failing tests:
media/W3C/video/networkState/networkState_during_loadstart.html
Comment 6 Build Bot 2014-06-24 11:56:24 PDT
Created attachment 233724 [details]
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-15  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5