Summary: | Convert TileController and TileGrid from ObjC to C++ | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brent Fulgham <bfulgham> | ||||
Component: | Layout and Rendering | Assignee: | Brent Fulgham <bfulgham> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | bfulgham, commit-queue, simon.fraser, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 133704 | ||||||
Attachments: |
|
Description
Brent Fulgham
2014-06-12 13:43:00 PDT
Created attachment 232994 [details]
Patch
Attachment 232994 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/graphics/ca/mac/TileGrid.cpp:186: Multi line control clauses should use braces. [whitespace/braces] [4]
ERROR: Source/WebCore/platform/graphics/ca/mac/TileGrid.cpp:259: Missing space after , [whitespace/comma] [3]
Total errors found: 2 in 7 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 232994 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=232994&action=review > Source/WebCore/platform/graphics/ca/mac/TileController.cpp:386 > + FloatRect visiblePart(CGRectOffset([tileLayer frame], tileTranslation.x(), tileTranslation.y())); looks like ObjC to me! > Source/WebCore/platform/graphics/ca/mac/TileController.cpp:386 > - FloatRect visiblePart(CGRectOffset([tileLayer frame], tileTranslation.x(), tileTranslation.y())); > + FloatRect visiblePart(CGRectOffset(frameForLayer(tileLayer), tileTranslation.x(), tileTranslation.y())); wut. weird patch format, I guess? > Source/WebCore/platform/graphics/mac/WebLayer.h:31 > +#include <WebCore/FloatRect.h> we're in webcore, is there any need for WebCore/? Committed r169914: <http://trac.webkit.org/changeset/169914> Follow-up commit: r169919 <http://trac.webkit.org/changeset/169919> This was needed because Xcode only changed the logical folder names of the new files; they were meant to be moved from the 'mac' specific folder. Second follow up commit: Committed revision 169923. This was needed because 'TileController.h' must be marked as a Private header or else the WebKit2 build will fail. |