Bug 133802

Summary:

check-webkit-style should complain about C++ comments in Platform.h

Product:

WebKit

Reporter:

Brian Burg <burg>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, bshafiei, buildbot, commit-queue, glenn, jberta.u-szeged, mtiborinf, ossy, rniwa, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Proposed patch	none
Proposed patch	none
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2	none

Brian Burg

Reported 2014-06-12 09:55:14 PDT

(Filed for posterity...) It would not be too hard to make a new C checker that looks for the wrong syntax, and additionally runs the current C++ checker. This would help prevent build breaks like the one fixed here: <http://trac.webkit.org/changeset/169900>

Attachments
Proposed patch (5.06 KB, patch) 2014-09-01 01:07 PDT, Nagy Renátó	no flags	Details Formatted Diff Diff
Proposed patch (5.06 KB, patch) 2014-09-01 02:31 PDT, Nagy Renátó	no flags	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2 (927.86 KB, application/zip) 2014-09-01 07:12 PDT, Build Bot	no flags	Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2014-06-12 10:37:48 PDT

<rdar://problem/17289114>

Brian Burg

Comment 2 2014-06-12 13:17:30 PDT

A similar check for multi-line comments should be applied to the Inspector JS files, because the minified release and production builds strip out single-line comments and choke on multi-line comments.

Alexey Proskuryakov

Comment 3 2014-06-12 13:40:32 PDT

Alternatively, we could have a build step that verifies that the profile compiles. That would have the benefit of catching mistakes in the profile at build time, with the downsides of it happening later than style checker, and only on Mac.

Nagy Renátó

Comment 4 2014-09-01 01:07:51 PDT

Created attachment 237442 [details] Proposed patch

Nagy Renátó

Comment 5 2014-09-01 02:31:02 PDT

Created attachment 237444 [details] Proposed patch

Build Bot

Comment 6 2014-09-01 07:12:45 PDT

Comment on attachment 237444 [details] Proposed patch Attachment 237444 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6202974145609728 New failing tests: compositing/checkerboard.html accessibility/adjacent-continuations-cause-assertion-failure.html animations/animation-border-overflow.html http/tests/appcache/abort-cache-onchecking.html http/tests/appcache/abort-cache-onchecking-resource-404.html animations/animation-controller-drt-api.html accessibility/alt-tag-on-image-with-nonimage-role.html

Build Bot

Comment 7 2014-09-01 07:12:50 PDT

Created attachment 237449 [details] Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-09 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5

Csaba Osztrogonác

Comment 8 2014-09-02 08:27:28 PDT

Comment on attachment 237444 [details] Proposed patch LGTM, r=me.

WebKit Commit Bot

Comment 9 2014-09-02 09:03:55 PDT

Comment on attachment 237444 [details] Proposed patch Clearing flags on attachment: 237444 Committed r173174: <http://trac.webkit.org/changeset/173174>

WebKit Commit Bot

Comment 10 2014-09-02 09:04:03 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.