Bug 133792

Summary: Remove deprecated API warnings in WebKit/Tools/MiniBrowser/efl/main.c
Product: WebKit Reporter: Tanay <tanay.c>
Component: WebKit Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2 none

Tanay
Reported 2014-06-12 04:00:04 PDT
/home/tanay.c/webkit-svn/WebKit/Tools/MiniBrowser/efl/main.c: In function ‘show_file_entry_dialog’: /home/tanay.c/webkit-svn/WebKit/Tools/MiniBrowser/efl/main.c:1044:5: warning: ‘elm_fileselector_entry_is_save_set’ is deprecated (declared at /home/tanay.c/webkit-svn/WebKit/WebKitBuild/Dependencies/Root/include/elementary-1/elm_deprecated.h:1585) [-Wdeprecated-declarations] elm_fileselector_entry_is_save_set(fs_entry, EINA_TRUE); ^ /home/tanay.c/webkit-svn/WebKit/Tools/MiniBrowser/efl/main.c:1047:5: warning: ‘elm_fileselector_entry_path_set’ is deprecated (declared at /home/tanay.c/webkit-svn/WebKit/WebKitBuild/Dependencies/Root/include/elementary-1/elm_deprecated.h:1471) [-Wdeprecated-declarations] elm_fileselector_entry_path_set(fs_entry, default_text); ^ /home/tanay.c/webkit-svn/WebKit/Tools/MiniBrowser/efl/main.c:1074:5: warning: ‘elm_fileselector_entry_path_get’ is deprecated (declared at /home/tanay.c/webkit-svn/WebKit/WebKitBuild/Dependencies/Root/include/elementary-1/elm_deprecated.h:1485) [-Wdeprecated-declarations] Eina_Stringshare *file_path = ok ? eina_stringshare_add(elm_fileselector_entry_path_get(fs_entry)) : NULL; ^ /home/tanay.c/webkit-svn/WebKit/Tools/MiniBrowser/efl/main.c: In function ‘window_create’: /home/tanay.c/webkit-svn/WebKit/Tools/MiniBrowser/efl/main.c:1747:5: warning: ‘elm_entry_scrollbar_policy_set’ is deprecated (declared at /home/tanay.c/webkit-svn/WebKit/WebKitBuild/Dependencies/Root/include/elementary-1/elm_deprecated.h:661) [-Wdeprecated-declarations] elm_entry_scrollbar_policy_set(window->url_bar, ELM_SCROLLER_POLICY_OFF, ELM_SCROLLER_POLICY_OFF); ^ /home/tanay.c/webkit-svn/WebKit/Tools/MiniBrowser/efl/main.c:1784:5: warning: ‘elm_entry_scrollbar_policy_set’ is deprecated (declared at /home/tanay.c/webkit-svn/WebKit/WebKitBuild/Dependencies/Root/include/elementary-1/elm_deprecated.h:661) [-Wdeprecated-declarations] elm_entry_scrollbar_policy_set(window->search.search_field, ELM_SCROLLER_POLICY_OFF, ELM_SCROLLER_POLICY_OFF);
Attachments
Patch (3.08 KB, patch)
2014-06-12 05:40 PDT, Tanay
no flags
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2 (523.79 KB, application/zip)
2014-06-12 15:14 PDT, Build Bot
no flags
Tanay
Comment 1 2014-06-12 05:40:54 PDT
Build Bot
Comment 2 2014-06-12 15:14:38 PDT
Comment on attachment 232948 [details] Patch Attachment 232948 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/4704417517404160 New failing tests: media/W3C/video/currentSrc/currentSrc_empty_if_no_src.html
Build Bot
Comment 3 2014-06-12 15:14:40 PDT
Created attachment 232996 [details] Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-09 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Gyuyoung Kim
Comment 4 2014-06-16 18:47:07 PDT
Comment on attachment 232948 [details] Patch LGTM
WebKit Commit Bot
Comment 5 2014-06-16 19:18:25 PDT
Comment on attachment 232948 [details] Patch Clearing flags on attachment: 232948 Committed r170039: <http://trac.webkit.org/changeset/170039>
WebKit Commit Bot
Comment 6 2014-06-16 19:18:28 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.