| Summary: | [iOS WK2] Give WebKitTestRunner a viewport configuration with initial scale=1 for testing | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||
| Component: | New Bugs | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | andersca, benjamin, ddkilzer, dfarler, simon.fraser | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 133785 | ||||||
| Attachments: |
|
||||||
|
Description
Simon Fraser (smfr)
2014-06-11 17:41:24 PDT
Created attachment 232925 [details]
Patch
Comment on attachment 232925 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=232925&action=review > Source/WebKit2/UIProcess/API/ios/WKViewIOS.mm:247 > + WebPageProxy *webPageProxy = [_contentView page]; * on the wrong side. > Source/WebKit2/UIProcess/API/ios/WKViewIOS.mm:248 > + webPageProxy->setViewportConfigurationMinimumLayoutSize(WebCore::FloatSize(bounds.size)); You should also send setMaximumUnobscuredSize() so that we can use viewport units. You could set setViewportConfigurationMinimumLayoutSizeForMinimalUI() but there is no test for it. They should all take the same size in this case. > Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:2200 > + if (m_useTestingViewportConfiguration) { > + m_viewportConfiguration.setDefaultConfiguration(ViewportConfiguration::testingParameters()); > + return; > + } Shouldn't this be above the case with !frame? |