Bug 133755

Summary: Always inline JSValue::get() and Structure::get().
Product: WebKit Reporter: Andreas Kling <kling>
Component: JavaScriptCoreAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, kling, mhahnenberg, ossy, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Andreas Kling
Reported 2014-06-11 12:20:28 PDT
GetByVal micro-optimization cont'd.
Attachments
Patch (4.75 KB, patch)
2014-06-11 12:23 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Patch for landing (4.28 KB, patch)
2014-06-11 12:36 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2014-06-11 12:23:19 PDT
Created attachment 232887 [details] Patch
Andreas Kling
Comment 2 2014-06-11 12:24:49 PDT
On Ryosuke's microbenchmark from bug 133727: 46.78ms -> 35.70ms 46.64ms -> 35.61ms
Ryosuke Niwa
Comment 3 2014-06-11 12:25:59 PDT
Comment on attachment 232887 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=232887&action=review > Source/JavaScriptCore/ChangeLog:12 > + Reviewed by NOBODY (OOPS!). This line should appear right beneath the bug URL.
Ryosuke Niwa
Comment 4 2014-06-11 12:36:21 PDT
Created attachment 232888 [details] Patch for landing
WebKit Commit Bot
Comment 5 2014-06-11 13:17:13 PDT
Comment on attachment 232888 [details] Patch for landing Clearing flags on attachment: 232888 Committed r169823: <http://trac.webkit.org/changeset/169823>
WebKit Commit Bot
Comment 6 2014-06-11 13:17:17 PDT
All reviewed patches have been landed. Closing bug.
Csaba Osztrogonác
Comment 7 2014-06-11 14:28:58 PDT
buildfix landed in r169834.
Note You need to log in before you can comment on or make changes to this bug.