Bug 133749

Summary:

WebKit2 iOS: Unable to open UI menu for "open in new tab" for links on yahoo.com

Product:

WebKit

Reporter:

Enrica Casucci <enrica>

Component:

WebKit2

Assignee:

Enrica Casucci <enrica>

Status:

RESOLVED FIXED

Severity:

Normal

Keywords:

InRadar

Priority:

Version:

528+ (Nightly build)

Hardware:

iPhone / iPad

OS:

Unspecified

Attachments:

Description	Flags
Patch	beidson: review+

Description Enrica Casucci 2014-06-11 10:46:53 PDT

This is a problem on iPad only.
Tap and hold on a link on the yahoo page does not show the link menu popover.

<rdar://problem/17165992>

Comment 1 Enrica Casucci 2014-06-11 10:49:32 PDT

Created attachment 232873 [details]
Patch

Comment 2 Enrica Casucci 2014-06-11 11:06:56 PDT

Committed revision 169813.

Comment 3 Darin Adler 2014-06-18 11:01:29 PDT

Comment on attachment 232873 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=232873&action=review

> Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:1698
> +                info.url = [(NSURL *)linkElement->document().completeURL(stripLeadingAndTrailingHTMLSpaces(linkElement->getAttribute(HTMLNames::hrefAttr))) absoluteString];

What does “encoded” mean? Why is conversion to an NSURL the best way to do this? Why is absoluteString the right method to use rather than, say, the userVisibleString function?