Bug 133738

Summary:

[EFL] Change expectations for three failing layout tests

Product:

WebKit

Reporter:

Andrzej Badowski <a.badowski>

Component:

WebKit EFL

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bjonesbe, commit-queue, lucas.de.marchi

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Linux

Attachments:

Description	Flags
proposed patch	none

Andrzej Badowski

Reported 2014-06-11 08:37:02 PDT

The following three layout tests fail on EFL WK2 since the inception (about 2014-05-28), since 2014-06-01 only timeouts: css3/viewport-percentage-lengths/viewport-percentage-lengths-anonymous-block.html css3/viewport-percentage-lengths/viewport-percentage-lengths-percent-size-child.html css3/viewport-percentage-lengths/viewport-percentage-lengths-relative-font-size.html

Attachments
proposed patch (1.45 KB, patch) 2014-06-11 08:42 PDT, Andrzej Badowski	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Andrzej Badowski

Comment 1 2014-06-11 08:42:10 PDT

Created attachment 232867 [details] proposed patch

Bem Jones-Bey

Comment 2 2014-06-11 09:26:47 PDT

I'm betting those are timing out because the onresize event doesn't fire in DRT/WTR on the EFL port. Darin fixed DRT/WTR for the Mac port in Bug 133351 when he changed the tests to use the onresize event. He made an attempt to fix the other ports as well, but it is possible that fix didn't work for the EFL port. Hopefully it's an easy fix. In the meantime, would you like me to CQ+ this patch?

WebKit Commit Bot

Comment 3 2014-06-12 02:42:28 PDT

Comment on attachment 232867 [details] proposed patch Clearing flags on attachment: 232867 Committed r169888: <http://trac.webkit.org/changeset/169888>

WebKit Commit Bot

Comment 4 2014-06-12 02:42:31 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.