Bug 133728

Summary:

[GTK] Remove all deprecated API from GObject DOM bindings

Product:

WebKit

Reporter:

Carlos Garcia Campos <cgarcia>

Component:

Bindings

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bunhere, cdumez, cmarcelo, commit-queue, esprehn+autocc, gustavo, gyuyoung.kim, kangil.han, kondapallykalyan, pnormand, rakuco, sergio, svillar

Priority:

Keywords:

Gtk

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

133724, 133726

Attachments:

Description	Flags
Patch	mrobinson: review+

Description Carlos Garcia Campos 2014-06-11 01:06:43 PDT

And all the exceptions in the code generator because of the deprecated stuff.

Comment 1 Carlos Garcia Campos 2014-06-12 03:36:10 PDT

Created attachment 232942 [details]
Patch

Comment 2 WebKit Commit Bot 2014-06-12 03:38:01 PDT

Attachment 232942 [details] did not pass style-queue:


ERROR: Tools/gtk/webkitdom.py:30:  multiple statements on one line (semicolon)  [pep8/E702] [5]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Martin Robinson 2014-06-12 07:53:28 PDT

Comment on attachment 232942 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=232942&action=review

> Tools/gtk/webkitdom.py:30
> +    DELETED_CLASSES = [];

I think it's worth getting rid of write_deleted_classes now altogether. We should just try to make sure to not break API in the future.

Comment 4 Carlos Garcia Campos 2014-06-12 08:20:06 PDT

(In reply to comment #3)
> (From update of attachment 232942 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=232942&action=review
> 
> > Tools/gtk/webkitdom.py:30
> > +    DELETED_CLASSES = [];
> 
> I think it's worth getting rid of write_deleted_classes now altogether. We should just try to make sure to not break API in the future.

We have never broken the API on purpose, idl files change and we can't control that. So, I prefer to keep all the deprecation machinery for the future.

Comment 5 Carlos Garcia Campos 2014-06-12 08:20:47 PDT

The build break is because a clean build is required

Comment 6 Martin Robinson 2014-06-12 12:10:28 PDT

Comment on attachment 232942 [details]
Patch

I'm not wild about the dead code. I really think we should also just stop generating "unstable" API to prevent API breaks in the future, so that we can remove this code without worrying. Please at least consider this path.

Comment 7 Carlos Garcia Campos 2014-06-12 22:51:46 PDT

(In reply to comment #6)
> (From update of attachment 232942 [details])
> I'm not wild about the dead code. I really think we should also just stop generating "unstable" API to prevent API breaks in the future, so that we can remove this code without worrying. Please at least consider this path.

Thanks for the review. Ok, I'll remove the dead code, but it will be  pain to bring all that back from history if we need it again eventually. If we have users using unstable API, in the worst case, they will just need to add an include header and define a macro, and then recompile. Note that changes in the unstable API are not API breaks, so we don't need to worry about them.

Comment 8 Carlos Garcia Campos 2014-06-12 23:40:39 PDT

Committed r169931: <http://trac.webkit.org/changeset/169931>