Bug 133718

Summary:

DFG::ByteCodeParser should emit native call/construct only in FTL mode, since the DFG backend can't do anything about them and the presence of function checks just means less efficient code

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

JavaScriptCore

Assignee:

Matthew Mirman <mmirman>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

barraclough, fpizlo, ggaren, mark.lam, mhahnenberg, msaboff, oliver, sam

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Added check for ftl mode before emitting native calls	fpizlo: review+

Description Filip Pizlo 2014-06-10 21:19:20 PDT

...

Comment 1 Matthew Mirman 2014-06-11 11:48:06 PDT

Created attachment 232878 [details]
Added check for ftl mode before emitting native calls

For branch ftlopt.  Passed all tests, both 32 and 64 bit.

Comment 2 Filip Pizlo 2014-06-11 11:55:27 PDT

Comment on attachment 232878 [details]
Added check for ftl mode before emitting native calls

Cool!  I will land.

Comment 3 Filip Pizlo 2014-06-11 12:57:16 PDT

Landed in http://trac.webkit.org/changeset/169819