Bug 133718

Summary:

DFG::ByteCodeParser should emit native call/construct only in FTL mode, since the DFG backend can't do anything about them and the presence of function checks just means less efficient code

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

JavaScriptCore

Assignee:

Matthew Mirman <mmirman>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

barraclough, fpizlo, ggaren, mark.lam, mhahnenberg, msaboff, oliver, sam

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Added check for ftl mode before emitting native calls	fpizlo: review+

Filip Pizlo

Reported 2014-06-10 21:19:20 PDT

...

Attachments
Added check for ftl mode before emitting native calls (1.58 KB, patch) 2014-06-11 11:48 PDT, Matthew Mirman	fpizlo: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Matthew Mirman

Comment 1 2014-06-11 11:48:06 PDT

Created attachment 232878 [details] Added check for ftl mode before emitting native calls For branch ftlopt. Passed all tests, both 32 and 64 bit.

Filip Pizlo

Comment 2 2014-06-11 11:55:27 PDT

Comment on attachment 232878 [details] Added check for ftl mode before emitting native calls Cool! I will land.

Filip Pizlo

Comment 3 2014-06-11 12:57:16 PDT

Landed in http://trac.webkit.org/changeset/169819

Note You need to log in before you can comment on or make changes to this bug.